Last Call Review of draft-ietf-ospf-sbfd-discriminator-04
review-ietf-ospf-sbfd-discriminator-04-genart-lc-resnick-2016-04-18-00

Request Review of draft-ietf-ospf-sbfd-discriminator
Requested rev. no specific revision (document currently at 06)
Type Last Call Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2016-04-26
Requested 2016-03-24
Authors Carlos Pignataro, Manav Bhatia, Sam Aldrin, Trilok Ranganath
Draft last updated 2016-04-18
Completed reviews Genart Last Call review of -04 by Pete Resnick (diff)
Opsdir Telechat review of -03 by Scott Bradner (diff)
Rtgdir Early review of -00 by John Drake (diff)
Rtgdir Early review of -01 by Adrian Farrel (diff)
Assignment Reviewer Pete Resnick
State Completed
Review review-ietf-ospf-sbfd-discriminator-04-genart-lc-resnick-2016-04-18
Reviewed rev. 04 (document currently at 06)
Review result Ready
Review completed: 2016-04-18

Review
review-ietf-ospf-sbfd-discriminator-04-genart-lc-resnick-2016-04-18

I am the assigned Gen-ART reviewer for this draft. The General Area 
Review Team (Gen-ART) reviews all IETF documents being processed by the 
IESG for the IETF Chair. Please treat these comments just like any other 
last call comments. For more information, please see the FAQ at 
<‚Äčhttp://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-ietf-ospf-sbfd-discriminator-04
Reviewer: Pete Resnick
Review Date: 2016-04-18
IETF LC End Date: 2016-04-26
IESG Telechat date: 2016-05-05

Summary: This draft is ready for publication as a Proposed Standard RFC.

Major issues: None

Minor issues: None

Nits/editorial comments: Two clarifications, one typo:

2.1:

OLD
    Type - S-BFD Discriminator TLV Type
NEW
    Type - S-BFD Discriminator TLV Type (TBD [to be filled in by IANA])
END

OLD
    Length - Total length of the discriminator (Value field) in octets,
    not including the optional padding.  The Length is a multiple of 4
    octets, and consequently specifies how many Discriminators are
    included in the TLV.
NEW
    Length - Total length of the discriminator(s) that appear in the
    Value field, in octets. Each discriminator is 4 octets, so the 
Length
    is 4 times the number of Discriminators included in the TLV. There 
is
    no optional padding for this field.
END

2.2:

OLD
    Note that the S-BFD session may be required to pan multiple areas
NEW
    Note that the S-BFD session may be required to span multiple areas
END

-- 
Pete Resnick <http://www.qualcomm.com/~presnick/>
Qualcomm Technologies, Inc. - +1 (858)651-4478