Last Call Review of draft-ietf-softwire-map-mib-12
review-ietf-softwire-map-mib-12-opsdir-lc-wu-2018-04-06-00

Request Review of draft-ietf-softwire-map-mib
Requested rev. no specific revision (document currently at 13)
Type Last Call Review
Team Ops Directorate (opsdir)
Deadline 2018-02-26
Requested 2018-02-12
Other Reviews Genart Last Call review of -12 by Meral Shirazipour (diff)
Secdir Last Call review of -12 by Robert Sparks (diff)
Review State Completed
Reviewer Qin Wu
Review review-ietf-softwire-map-mib-12-opsdir-lc-wu-2018-04-06
Posted at https://mailarchive.ietf.org/arch/msg/ops-dir/bwLLEClqoJjzcDbQZKFgd-mGmDI
Reviewed rev. 12 (document currently at 13)
Review result Ready
Draft last updated 2018-04-06
Review completed: 2018-04-06

Review
review-ietf-softwire-map-mib-12-opsdir-lc-wu-2018-04-06

I have reviewed this document as part of the Operational directorate's ongoing effort to review all IETF documents being processed by the IESG.
These comments were written with the intent of improving the operational aspects of the IETF drafts. Comments that are not addressed in last call may be included in AD reviews during the IESG review.  Document editors and WG chairs should treat these comments just like any other last call comments.
This draft defines MIB for MAP-E for use with SNMP. It is well written and I have no concern on operational aspects. Here are a few editorial comments as follows:
1. Please remove unused reference RFC7598.
2. Section 4.1, the 1st paragraph, last sentence
Can you list which parts of the IF-MIB in more details here the MAP-E depends on?
3. Section 4.1.1 two categories on mapping rules
In MIB module definition, it looks the mapping rule is divided into three categories, i.e., BMR, FMR and BMRandFMR,which is not consistent with two categories classification defined in section 4.1.1, I am wondering whether we also have fmrandbmr, i.e., Forwarding Mapping Rule can also be basic Mapping Rule, in other words, is fmrandbmr same as bmrandfmr? Is fmrandbmr a set that belong to both fmr and bmr? Try to understand this, would it be great to clarify this in section 4.1.1.
4.Section 4.1.2 two kind of invalid packets
In MIB module definition, two MapSecurityCheckEntries are defined, one is
mapSecurityCheckInvalidv4, the other is mapSecurityCheckInvalidv4. I am wondering whether    these two entries are corresponding to two kind of invalid packets described in section 4.1.2. 
also I am not sure I understand payload source IPv4 address and port, are these payload source and port are referred to received packets’ source IPv4 address port mentioned in section 4.1.2.
5.Section 6
does this document request IANA to assign new OID under mib-2 or just use existing OID under mib-2?