Last Call Review of draft-josefsson-gss-capsulate-
review-josefsson-gss-capsulate-secdir-lc-lonvick-2011-04-21-00

Request Review of draft-josefsson-gss-capsulate
Requested rev. no specific revision (document currently at 05)
Type Last Call Review
Team Security Area Directorate (secdir)
Deadline 2011-05-04
Requested 2011-04-14
Authors Simon Josefsson, Love Astrand
Draft last updated 2011-04-21
Completed reviews Secdir Last Call review of -?? by Chris Lonvick
Assignment Reviewer Chris Lonvick
State Completed
Review review-josefsson-gss-capsulate-secdir-lc-lonvick-2011-04-21
Review completed: 2011-04-21

Review
review-josefsson-gss-capsulate-secdir-lc-lonvick-2011-04-21

Hi,

I have reviewed this document as part of the security directorate's
ongoing effort to review all IETF documents being processed by the
IESG.  These comments were written primarily for the benefit of the
security area directors.  Document editors and WG chairs should treat
these comments just like any other last call comments.

Overall, I find the document to be of good quality and ready to progress.



One editorial suggestion I'd make would be to either include or directly 


reference the security section of RFC 2743 in your own security 


considerations section.






Also, I'm just not partial towards the use of "otherwise" to describe a 


return code from gss_oid_equal.  Personally, I think it should be directly 


specified.






Finally, I think you have a formatting inconsistency in Section 4.1; the 


"otherwise" should be tabbed out to line up in the other column.




Regards,
Chris