Path Computation Element Communication Protocol (PCEP) Extensions for Establishing Relationships between Sets of Label Switched Paths and Virtual Networks
draft-ietf-pce-vn-association-11

# Internet AD comments for {draft-ietf-pce-vn-association-09}
CC @ekline

## Comments

### S4

* The format layout diagram, Figure 2, states that Length is variable, as
  does the text that follows it, but the use of the "|" at the end of the
  first word implied to me that it was actually a 16-bit integer.

  Perhaps change the end of this line to just be "//" or something?

  Alternatively, if this field is actually a 16-bit integer then I suggest
  clarifying the text that says it's "variable".

* Related: what should an implementation do if the length of the VN is zero?

** Section 4.

The Virtual Network Identifier is a human-readable
   string that identifies a VN and can be specified with the association
   information.  

Is this “associated information” conveyed with a VENDOR-INFORMATION-TLV?  If so, it would be clearer to say (something to the effect of):

NEW

The Virtual Network Identifier is a human-readable string that identifies a VN and can be specified with the association information conveyed in a VENDOR-INFORMATION-TLV.

# GEN AD review of draft-ietf-pce-vn-association-09

CC @larseggert

Thanks to Meral Shirazipour for the General Area Review Team (Gen-ART) review
(https://mailarchive.ietf.org/arch/msg/gen-art/_z38ZSXAEkWf_mmmUAEO5JWCMFk).

## Nits

All comments below are about very minor potential issues that you may choose to
address in some way - or ignore - as you see fit. Some were flagged by
automated tools (via https://github.com/larseggert/ietf-reviewtool), so there
will likely be some false positives. There is no need to let me know what you
did with these suggestions.

### Grammar/style

#### Section 3, paragraph 9
```
guration of VNAG IDs is not supported so there is no need for an Operator-Con
                                     ^^^
```
Use a comma before "so" if it connects two independent clauses (unless they are
closely connected and short).

## Notes

This review is in the ["IETF Comments" Markdown format][ICMF], You can use the
[`ietf-comments` tool][ICT] to automatically convert this review into
individual GitHub issues. Review generated by the [`ietf-reviewtool`][IRT].

[ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md
[ICT]: https://github.com/mnot/ietf-comments
[IRT]: https://github.com/larseggert/ietf-reviewtool