Last Call Review of draft-yegin-pana-encr-avp-
review-yegin-pana-encr-avp-genart-lc-carpenter-2012-07-15-00

Request Review of draft-yegin-pana-encr-avp
Requested rev. no specific revision (document currently at 10)
Type Last Call Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2012-07-26
Requested 2012-07-12
Draft last updated 2012-07-15
Completed reviews Genart Last Call review of -?? by Brian Carpenter
Genart Last Call review of -?? by Brian Carpenter
Secdir Last Call review of -?? by Yaron Sheffer
Assignment Reviewer Brian Carpenter
State Completed
Review review-yegin-pana-encr-avp-genart-lc-carpenter-2012-07-15
Review completed: 2012-07-15

Review
review-yegin-pana-encr-avp-genart-lc-carpenter-2012-07-15

Please see attached review.




I am the assigned Gen-ART reviewer for this draft. For background on
Gen-ART, please see the FAQ at
<

http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Please resolve these comments along with any other Last Call comments
you may receive.

Document: draft-yegin-pana-encr-avp-03.txt
Reviewer: Brian Carpenter
Review Date: 2012-07-14
IETF LC End Date: 2012-08-08
IESG Telechat date: 2012-08-16

Summary:  Ready
--------

Minor issue:
------------

IANA will probably figure this out, but I think it would have been better
to use TBD1 and TBD2 in the main text and note the suggested values
in the IANA Considerations:

"4.  Encryption-Algorithm AVP

   The Encryption-Algorithm AVP (AVP Code 12 ** needs IANA allocation
   **)"

"5.  Encr-Encap AVP

   The Encr-Encap AVP (AVP Code 13 ** needs IANA allocation **)"

"8.  IANA Considerations

   The following IANA actions are required by this specification:

      - Assignment of a standard PANA AVP code TBD for Encr-Encap AVP.

      - Assignment of a standard PANA AVP code TBD for Encryption-
      Algorithm AVP."