Last Call Review of draft-moriarty-pkcs12v1-1-03
review-moriarty-pkcs12v1-1-03-secdir-lc-tsou-2014-01-16-00

Request Review of draft-moriarty-pkcs12v1-1
Requested rev. no specific revision (document currently at 05)
Type Last Call Review
Team Security Area Directorate (secdir)
Deadline 2014-01-10
Requested 2013-12-19
Draft last updated 2014-01-16
Completed reviews Genart Last Call review of -03 by Francis Dupont (diff)
Secdir Last Call review of -03 by Tina Tsou (diff)
Opsdir Last Call review of -03 by Bert Wijnen (diff)
Assignment Reviewer Tina Tsou
State Completed
Review review-moriarty-pkcs12v1-1-03-secdir-lc-tsou-2014-01-16
Reviewed rev. 03 (document currently at 05)
Review result Has Nits
Review completed: 2014-01-16

Review
review-moriarty-pkcs12v1-1-03-secdir-lc-tsou-2014-01-16



























Dear all,




I have reviewed this document as part of the security directorate's


ongoing effort to review all IETF documents being processed by the


IESG.  These comments were written primarily for the benefit of the


security area directors. Document editors and WG chairs should treat


these comments just like any other last call comments.
















Most of the contents in this draft is taken directly from a published 

RSA
 document PKCS #12. In this version, nearly all the typos are 

corrected. I think this document is good enough for publication.










In security consideration, it is suggested to follow PKCS #5 (RFC2898) 

to
 select passwords. I realize that in RFC2898 there is no discussion 

about how to ensure a good randomness of the salt.  Therefore, I 

suggest
 to cite RFC4086.







Maybe there should also be a reference to Appendix B, just to put that Appendix into perspective ... saying that RFC 4086 is the superior guide, but for integrity protection
 only, the method of Appendix B may be adequate.










Typo: second line of Abstract


(Republication) From -> (Republication) from





Typo, Sec. 1.1, third from last bullet regarding SP 800-132


selection of a the -> selection of the





Nit: Appendix B, Sec. B.4


passwords and salt that was given in Appendix C


 -> passwords and salt that is given in Appendix C










Thank you,




Tina