Last Call Review of draft-ietf-tsvwg-tinymt32-01
review-ietf-tsvwg-tinymt32-01-genart-lc-bryant-2019-05-08-00

Request Review of draft-ietf-tsvwg-tinymt32
Requested rev. no specific revision (document currently at 06)
Type Last Call Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2019-05-13
Requested 2019-04-29
Draft last updated 2019-05-08
Completed reviews Genart Last Call review of -01 by Stewart Bryant (diff)
Secdir Last Call review of -01 by Carl Wallace (diff)
Assignment Reviewer Stewart Bryant
State Completed
Review review-ietf-tsvwg-tinymt32-01-genart-lc-bryant-2019-05-08
Posted at https://mailarchive.ietf.org/arch/msg/gen-art/IN4_bYpycigMutSLhGb1u_mf910
Reviewed rev. 01 (document currently at 06)
Review result Ready with Nits
Review completed: 2019-05-08

Review
review-ietf-tsvwg-tinymt32-01-genart-lc-bryant-2019-05-08

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-tsvwg-tinymt32-01
Reviewer: Stewart Bryant
Review Date: 2019-05-08
IETF LC End Date: 2019-05-13
IESG Telechat date: Not scheduled for a telechat

Summary: A well written document. There are a few review comments below that the authors should consider.

Major issues: None

Minor issues:

According to statistical tests (BigCrush in TestU01
<http://simul.iro.umontreal.ca/testu01/tu01.html> and AdaptiveCrush
<http://www.math.sci.hiroshima-u.ac.jp/~m-mat/MT/ADAPTIVE/>) the
 quality of the outputs of TinyMT seems pretty good, 

SB> It would be useful to the reader to specify  "pretty good"

=========

   The TinyMT32 PRNG initialization depends, among other things, on a
   parameter set -- namely (mat1, mat2, tmat) -- 

SB> These probably need a few words  of explanation on introduction.

========

   static void tinymt32_next_state (tinymt32_t * s);
SB> I assume that this notation is good C, but
SB> type space star space name does not seem common.
SB> This may confuse some readers. One more often 
SB> sees one of the spaces omitted.

=========

Nits/editorial comments:

   This specialisation aims at having a simple-to-use and deterministic
   PRNG, as explained below.

SB> I assume that "deterministic PRNG" is a term of the art, but the 
SB> it sounds like an oxymoron to the uninitiated. Perhaps a word
SB> or two would clarify.

=======