Last Call Review of draft-ietf-teas-yang-te-types-09
review-ietf-teas-yang-te-types-09-genart-lc-dunbar-2019-05-14-00

Request Review of draft-ietf-teas-yang-te-types
Requested rev. no specific revision (document currently at 10)
Type Last Call Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2019-05-16
Requested 2019-05-02
Draft last updated 2019-05-14
Completed reviews Yangdoctors Early review of -01 by Jan Lindblad (diff)
Rtgdir Last Call review of -06 by Ines Robles (diff)
Secdir Last Call review of -09 by Valery Smyslov (diff)
Genart Last Call review of -09 by Linda Dunbar (diff)
Assignment Reviewer Linda Dunbar
State Completed
Review review-ietf-teas-yang-te-types-09-genart-lc-dunbar-2019-05-14
Posted at https://mailarchive.ietf.org/arch/msg/gen-art/_2HpZ7QNcBCqN_rTAEgNwq_f0bU
Reviewed rev. 09 (document currently at 10)
Review result Ready with Nits
Review completed: 2019-05-14

Review
review-ietf-teas-yang-te-types-09-genart-lc-dunbar-2019-05-14

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-teas-yang-te-types-??
Reviewer: Linda Dunbar
Review Date: 2019-05-14
IETF LC End Date: 2019-05-16
IESG Telechat date: Not scheduled for a telechat

Summary:
This document defines all the "Identity" (or types) for TE data types. Therefore, it is hard to tell if all the types are completely specified without cross reference to the TE specification drafts. 
For example, I tried to cross reference to RFC3209 on "identity local-protection-desired", the words are not completely matched in RFC3209.  

(e.g. identity local-protection-desired {
base session-attributes-flags;
description "Fastreroute local protection is desired.";
reference "RFC3209";
}


It would make it much easier to validate the YANG model if the page number of the referenced RFC is listed in the Reference, or the actual TLV being referenced are described. 

Major issues:

Minor issues:

Nits/editorial comments:
Add the page number of the referenced RFC  to make it easier to validate the correctness of the "types", or describe the actual TLV being referenced .