Early Review of draft-ietf-softwire-iftunnel-03
review-ietf-softwire-iftunnel-03-yangdoctors-early-bierman-2019-04-03-00

Request Review of draft-ietf-softwire-iftunnel
Requested rev. no specific revision (document currently at 07)
Type Early Review
Team YANG Doctors (yangdoctors)
Deadline 2019-04-22
Requested 2019-04-02
Requested by √Čric Vyncke
Authors Mohamed Boucadair, Ian Farrer, Rajiv Asati
Draft last updated 2019-04-03
Completed reviews Yangdoctors Early review of -03 by Andy Bierman (diff)
Genart Last Call review of -04 by Dale Worley (diff)
Secdir Last Call review of -04 by Yaron Sheffer (diff)
Tsvart Last Call review of -04 by David Black (diff)
Comments
Mainly around readability and structure of the YANG modules. Thank you.
Assignment Reviewer Andy Bierman
State Completed
Review review-ietf-softwire-iftunnel-03-yangdoctors-early-bierman-2019-04-03
Reviewed rev. 03 (document currently at 07)
Review result Ready with Nits
Review completed: 2019-04-03

Review
review-ietf-softwire-iftunnel-03-yangdoctors-early-bierman-2019-04-03

The iana-tunnel-type module has no errors or nits of any kind.
The ietf-extension-example module has no errors of any kind, and 1 nit.
The document appears to follow all YANG usage guidelines (but 1) correctly.

I have a minor comment about the example module. I guess it has to use <CODE BEGINS>.
(The <EXAMPLE BEGINS> discussion did not go anywhere).

This module looks a little too real to average users, especially after tools extract it
from the RFC and put it in the YangModels repo under the standard/ietf/RFC directory.

You should rename the ietf-extension-example module to example-iftunnel-extension
(or anything starting with "example-"). The module should not begin with "ietf-" unless it is a real module.