Last Call Review of draft-ietf-sipcore-locparam-04
review-ietf-sipcore-locparam-04-secdir-lc-salz-2020-01-20-00

Request Review of draft-ietf-sipcore-locparam
Requested rev. no specific revision (document currently at 06)
Type Last Call Review
Team Security Area Directorate (secdir)
Deadline 2020-01-27
Requested 2020-01-13
Authors James Winterbottom, Roland Jesske, Bruno Chatras, Andrew Hutton
Draft last updated 2020-01-20
Completed reviews Genart Last Call review of -04 by Ines Robles (diff)
Secdir Last Call review of -04 by Rich Salz (diff)
Opsdir Last Call review of -06 by Tim Chown
Assignment Reviewer Rich Salz 
State Completed
Review review-ietf-sipcore-locparam-04-secdir-lc-salz-2020-01-20
Posted at https://mailarchive.ietf.org/arch/msg/secdir/zWVc6O24bWE5hbNTCXu7An9sqTI
Reviewed rev. 04 (document currently at 06)
Review result Has Nits
Review completed: 2020-01-20

Review
review-ietf-sipcore-locparam-04-secdir-lc-salz-2020-01-20

This is the security directorate (secdir) review for the sipcore-locparam draft. Secdir tries to review all documents. The primary intended recipient of this review if the security AD's; all others should consider this to be like any other last-call review.

Summary: ready with nits.

End of Sec 1 has a quote-based typo.

In Sec 3, "This document does not comment..." paragraph is a beautiful acceptance of reality.

In Sec 6, do proxies normally add themselves to the Record-Route field?  If so, that might be worth mentioning explicitly.

In Sec 7, looks good.  A couple of typo's "multiple*S* locations" and "hop-<SPACE>by-hop" and "an<SPACE>other domain."