Last Call Review of draft-ietf-pwe3-iccp-stp-04

Request Review of draft-ietf-pwe3-iccp-stp
Requested rev. no specific revision (document currently at 05)
Type Last Call Review
Team Security Area Directorate (secdir)
Deadline 2015-09-23
Requested 2015-09-10
Authors Mingui Zhang, Huafeng Wen, Jie Hu
Draft last updated 2015-09-24
Completed reviews Genart Last Call review of -04 by Brian Carpenter (diff)
Genart Telechat review of -04 by Brian Carpenter (diff)
Secdir Last Call review of -04 by Shawn Emery (diff)
Assignment Reviewer Shawn Emery
State Completed
Review review-ietf-pwe3-iccp-stp-04-secdir-lc-emery-2015-09-24
Reviewed rev. 04 (document currently at 05)
Review result Has Nits
Review completed: 2015-09-24


I have reviewed this document as part of the security directorate's
ongoing effort to review all IETF documents being processed by the IESG.
These comments were written primarily for the benefit of the security
area directors. Document editors and WG chairs should treat these
comments just like any other last call comments.

This draft specifies a Spanning Tree Protocol (STP) application for the
Inter-Chassis Communication Protocol (ICCP).

The security considerations section does exist and refers to the base ICCP
specification, RFC 7275, for applicability.  7275 lists the security
constraints and limitations sufficiently when considering the reviewed draft.
The section goes on to describe potential DoS attacks as described in 7275
and provides a single example to mitigate such an attack.  Even though this
coverage is fairly sparse, 7275 outlines a more comprehensive list of thwarting
potential threats.

General comments:


Editorial comments:

PE, PW, AC, CE, and LDP are never expanded.

s/need be active/need to be active/

s/such system/such systems/

s/that support ICCP/that supports ICCP/

s/on CE or PE/on the CE or PE/

s/attack on channel/attack on a channel/

s/careful attack on channel/a careful attack on a channel/