Telechat Review of draft-ietf-pim-source-discovery-bsr-11
review-ietf-pim-source-discovery-bsr-11-rtgdir-telechat-dimitri-2018-01-30-00

Request Review of draft-ietf-pim-source-discovery-bsr
Requested rev. no specific revision (document currently at 12)
Type Telechat Review
Team Routing Area Directorate (rtgdir)
Deadline 2018-01-23
Requested 2017-12-20
Requested by Alvaro Retana
Draft last updated 2018-01-30
Completed reviews Rtgdir Telechat review of -11 by Papadimitriou Dimitri (diff)
Genart Last Call review of -07 by Stewart Bryant (diff)
Secdir Last Call review of -07 by Liang Xia (diff)
Opsdir Last Call review of -07 by Joel Jaeggli (diff)
Genart Telechat review of -08 by Stewart Bryant (diff)
Tsvart Telechat review of -08 by David Black (diff)
Assignment Reviewer Papadimitriou Dimitri
State Completed
Review review-ietf-pim-source-discovery-bsr-11-rtgdir-telechat-dimitri-2018-01-30
Reviewed rev. 11 (document currently at 12)
Review result Has Nits
Review completed: 2018-01-30

Review
review-ietf-pim-source-discovery-bsr-11-rtgdir-telechat-dimitri-2018-01-30

Couldn't find the template for experiment drafts, but I think this kind of documents deserve its specific template

Summary:

Points to be clarified are related to 

1.the flooding boundary. The document refers to PIM domain defined in RFC 4601 

" A domain in this context is a contiguous set of routers that all implement PIM and are
   configured to operate within a common boundary."

And states " PFM messages are generally forwarded hop by hop to all PIM routers."

what now defines a PIM domain: the PFM flooding boundary or the PIM execution domain. 

2. Modified TLV (statement " Some TLVs may be omitted or modified in the forwarded message." - example a boundary router changes the Src Address in the GSH TLV to its own address - is that allowed/expected ? actually the document doesn't explain or justify the need to "modify" TLV in forwarded messages.


3. Section 4.2 states 

   "In order to meet the timing requirements, sending of the message may
   have to be delayed a small amount of time."

   Quantify "small amount of time"



Editorial:

First paragraph first sentence: add reference to PIM-SM

Second paragraph fifth sentence: add reference to SSM

Last paragraph

o) Refers to "parameters" please differentiate so-called architectural constants from configurable parameters. Cf.RFC 2328 for a good example.

o) Suggest to write last paragraph as numbered points to facilitate their clearing as more experience from the field is being obtained. 


Dimitri