Last Call Review of draft-ietf-pim-msdp-yang-12
review-ietf-pim-msdp-yang-12-secdir-lc-roca-2020-01-29-00

Request Review of draft-ietf-pim-msdp-yang
Requested rev. no specific revision (document currently at 18)
Type Last Call Review
Team Security Area Directorate (secdir)
Deadline 2020-01-30
Requested 2020-01-15
Authors Xufeng Liu, Zheng Zhang, Anish Peter, Mahesh Sivakumar, Feng Guo, Pete McAllister
Draft last updated 2020-01-29
Completed reviews Yangdoctors Early review of -13 by Reshad Rahman (diff)
Yangdoctors Last Call review of -16 by Reshad Rahman (diff)
Yangdoctors Last Call review of -12 by Reshad Rahman (diff)
Rtgdir Last Call review of -08 by Yingzhen Qu (diff)
Secdir Last Call review of -12 by Vincent Roca (diff)
Assignment Reviewer Vincent Roca 
State Completed
Review review-ietf-pim-msdp-yang-12-secdir-lc-roca-2020-01-29
Posted at https://mailarchive.ietf.org/arch/msg/secdir/wkYvxrGQKp6vcEyZew_rSHzcgpg
Reviewed rev. 12 (document currently at 18)
Review completed: 2020-01-29

Review
review-ietf-pim-msdp-yang-12-secdir-lc-roca-2020-01-29

Hello,

I have reviewed this document as part of the security directorate’s ongoing
effort to review all IETF documents being processed by the IESG. These
comments were written primarily for the benefit of the security area
directors.  Document editors and WG chairs should treat these comments just
like any other last call comments.

Summary: Ready with nits


The security considerations section is globally well writen and addresses
important topics. I don't have major comments.

Details:
- it is said that "(i.e., config true, which is the default)".
  I've searched in the YANG model and only found "config false" entries which seems to contradict what is said in section 5.

- Section 2.1 says: "This model can be used to configure and manage MSDP protocols." (with a final "s") which suggests there could be several MSDP protocols. I think it's a mistake.

Cheers,    Vincent