Last Call Review of draft-ietf-ospf-yang-23
review-ietf-ospf-yang-23-secdir-lc-santesson-2019-07-15-00

Request Review of draft-ietf-ospf-yang
Requested rev. no specific revision (document currently at 29)
Type Last Call Review
Team Security Area Directorate (secdir)
Deadline 2019-07-17
Requested 2019-07-02
Authors Derek Yeung, Yingzhen Qu, Zhaohui Zhang, Ing-Wher Chen, Acee Lindem
Draft last updated 2019-07-15
Completed reviews Yangdoctors Last Call review of -09 by Ladislav Lhotka (diff)
Yangdoctors Last Call review of -23 by Ladislav Lhotka (diff)
Rtgdir Last Call review of -23 by Ravi Singh (diff)
Genart Last Call review of -23 by Erik Kline (diff)
Secdir Last Call review of -23 by Stefan Santesson (diff)
Assignment Reviewer Stefan Santesson
State Completed
Review review-ietf-ospf-yang-23-secdir-lc-santesson-2019-07-15
Posted at https://mailarchive.ietf.org/arch/msg/secdir/h94M4V3CBrQXuFDdreOLatw4a9g
Reviewed rev. 23 (document currently at 29)
Review result Has Nits
Review completed: 2019-07-15

Review
review-ietf-ospf-yang-23-secdir-lc-santesson-2019-07-15

This document seems to have a reasonable security considerations section.

As a nit, I notice that the abbreviation OSPF is not written out or explained at all in this document.
One should hope that most people that find their way to this document are familiar with OSPF, but I still believe that is is appropriate for all IETF RFC to write out and briefly explain/reference abbreviations.

In summary this document seems well written