Last Call Review of draft-ietf-ospf-te-link-attr-reuse-12
review-ietf-ospf-te-link-attr-reuse-12-genart-lc-dunbar-2020-05-28-00

Request Review of draft-ietf-ospf-te-link-attr-reuse
Requested rev. no specific revision (document currently at 16)
Type Last Call Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2020-05-29
Requested 2020-05-14
Authors Peter Psenak, Les Ginsberg, Wim Henderickx, Jeff Tantsura, John Drake
Draft last updated 2020-05-28
Completed reviews Rtgdir Last Call review of -07 by Daniele Ceccarelli (diff)
Rtgdir Last Call review of -12 by Daniele Ceccarelli (diff)
Genart Last Call review of -12 by Linda Dunbar (diff)
Tsvart Last Call review of -12 by Michael Scharf (diff)
Opsdir Last Call review of -12 by Scott Bradner (diff)
Genart Telechat review of -14 by Linda Dunbar (diff)
Opsdir Telechat review of -14 by Scott Bradner (diff)
Assignment Reviewer Linda Dunbar
State Completed
Review review-ietf-ospf-te-link-attr-reuse-12-genart-lc-dunbar-2020-05-28
Posted at https://mailarchive.ietf.org/arch/msg/gen-art/XpQBo5G7DMwfHVTt1qoFwznACB8
Reviewed rev. 12 (document currently at 16)
Review result Not Ready
Review completed: 2020-05-28

Review
review-ietf-ospf-te-link-attr-reuse-12-genart-lc-dunbar-2020-05-28

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-ospf-te-link-attr-reuse-??
Reviewer: Linda Dunbar
Review Date: 2020-05-28
IETF LC End Date: 2020-05-29
IESG Telechat date: Not scheduled for a telechat

Summary: this document introduces a new link attribute advertisement in OSPFv2 and OSPFv3 to address general link properties needed for new applications, such as Segment Routing. 

Major issues:  
The document has good description on the TLV structure of the Application specific Advertisements, but fails to describe what are the NEW Link attributes needed by Segment Routing. 
Page 7 (section 5) has a really good description on all the link properties added to OSFP (RFC4203, RFC 7308, RFC7471, RFC3630) to achieve TE. 
I can see Segment Routing would need each node to advertise its own SID and the SIDs of adjacent nodes. Can't they be encoded (or extended) in OSPF's NODE ID?   


Minor issues:

Nits/editorial comments:

Best regards, 

Linda Dunbar