Last Call Review of draft-ietf-netmod-factory-default-07
review-ietf-netmod-factory-default-07-yangdoctors-lc-moberg-2019-11-27-00

Request Review of draft-ietf-netmod-factory-default-05
Requested rev. 05 (document currently at 09)
Type Last Call Review
Team YANG Doctors (yangdoctors)
Deadline 2019-11-15
Requested 2019-11-01
Requested by Kent Watsen
Authors Qin Wu, Bal√°zs Lengyel, Ye Niu
Draft last updated 2019-11-27
Completed reviews Yangdoctors Last Call review of -07 by Carl Moberg (diff)
Assignment Reviewer Carl Moberg
State Completed
Review review-ietf-netmod-factory-default-07-yangdoctors-lc-moberg-2019-11-27
Posted at https://mailarchive.ietf.org/arch/msg/yang-doctors/gBlJ8tS-Om7VI4TNIGH2VgZkpmA
Reviewed rev. 07 (document currently at 09)
Review result Ready with Nits
Review completed: 2019-11-27

Review
review-ietf-netmod-factory-default-07-yangdoctors-lc-moberg-2019-11-27

This is my YANG doctors review of the ietf-factory-default.yang module as
part of draft-ietf-netmod-factory-default-07.

The module cleanly passes validation using the YANG validator site and
I have successfully loaded it into one NETCONF server implementation.

This module is ready with a cosmetic nit and a suggestion.

I suggest fixing the following textual nit:

OLD
       configuration datastores (i.e.,<running> , <startup><candidate>) to
       their factory default content.";

NEW:
       configuration datastores (i.e. <running>, <startup>, and
       <candidate>) to their factory default content.";

I suggest adding a revision-date to the filename in the <CODE BEGINS> block.

OLD:
 <CODE BEGINS> file "ietf-factory-default.yang"

 NEW:
 <CODE BEGINS> file "ietf-factory-default@2019-11-27.yang"

 (Obviously replacing the date with the release date of the module)