Telechat Review of draft-ietf-netconf-nmda-netconf-06
review-ietf-netconf-nmda-netconf-06-rtgdir-telechat-berger-2018-07-30-00

Request Review of draft-ietf-netconf-nmda-netconf
Requested rev. no specific revision (document currently at 08)
Type Telechat Review
Team Routing Area Directorate (rtgdir)
Deadline 2018-07-13
Requested 2018-06-27
Requested by Alvaro Retana
Authors Martin Björklund, Jürgen Schönwälder, Philip Shafer, Kent Watsen, Robert Wilton
Draft last updated 2018-07-30
Completed reviews Yangdoctors Last Call review of -03 by Ebben Aries (diff)
Rtgdir Telechat review of -06 by Lou Berger (diff)
Secdir Last Call review of -06 by Christian Huitema (diff)
Genart Last Call review of -06 by Christer Holmberg (diff)
Opsdir Telechat review of -06 by Carlos Pignataro (diff)
Assignment Reviewer Lou Berger
State Completed
Review review-ietf-netconf-nmda-netconf-06-rtgdir-telechat-berger-2018-07-30
Reviewed rev. 06 (document currently at 08)
Review result Has Issues
Review completed: 2018-07-30

Review
review-ietf-netconf-nmda-netconf-06-rtgdir-telechat-berger-2018-07-30

Hello,

I have been selected as the Routing Directorate reviewer for this draft. 
The Routing Directorate seeks to review all routing or routing-related 
drafts as they pass through IETF last call and IESG review, and 
sometimes on special request. The purpose of the review is to provide 
assistance to the Routing ADs. For more information about the Routing 
Directorate, please see 
​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs, it 
would be helpful if you could consider them along with any other IETF 
Last Call comments that you receive, and strive to resolve them through 
discussion or by updating the draft.

Document: draft-ietf-netconf-nmda-netconf06.txt
Reviewer: Lou Berger
Review Date: July 30, 2018
IETF LC End Date: date-if-known
Intended Status: Standards Track

Summary:

I have some minor concerns about this document that I think should be 
resolved before publication.

Comments:

The document is is generally well written and easy to read.  There are 
several places where I'm sure the authors know exactly what they intend, 
but the text could be revised to help along those less familiar with the 
work.  There is also one miss-marked RFC Update reference.

Major Issues:

<none>

Minor Issues:

- Cover/Abstract
    Updates: 7950

    The update to
    RFC 7950 requires the usage of I-D.ietf-netconf-rfc7895bis by NETCONF
    servers implementing the Network Management Datastore Architecture.

If I read this and the referenced document correctly, this is saying 
that I-D.ietf-netconf-rfc7895bis updates which version of YANG library 
is supported by implementations RFC7950 that support NMDA.  If this is 
the correct reading, this document doesn't update RFC7950, but rather 
I-D.ietf-netconf-rfc7895bis updates 7950. (this omission was noted in a 
separate message.)

- section 3.1.1.

    The "config-filter" parameter can be used to retrieve only "config
    true" or "config false" nodes.

    also
          leaf config-filter {
            type boolean;
            description
              "Filter for nodes with the given value for their
               'config' property.";
          }

So this means:
     absent = provide all
     true = provide only true
     false = provide only false

Right? Either way, I think this could be clarified a bit.  At least say 
what behavior is expected when the leaf is omitted.

Nits:

- the orders of sections 3.1.1.1. and 3.1.1.2. should be reversed to 
match the module ordering.

- Section 3.1.2:

    The "default-operation" parameter is a copy of the
    "default-operation" parameter of the <edit-config> operation.

    The "edit-content" choice mirrors the "edit-content" choice of the
    <edit-config> operation.  Note, however, that the "config" element in
    the "edit-content" choice of <edit-data> uses "anydata" (introduced
    in YANG 1.1) while the "config" element in the "edit-content" choice
    of <edit-config> used "anyxml".

It's fine to say that these nodes mirror <edit-config> nodes, but this 
document should at least summarize the function of each, e.g.,
     The "default-operation" parameter selects the default operation
     for this request. It is a copy....