Last Call Review of draft-ietf-marf-authfailure-report-
review-ietf-marf-authfailure-report-genart-lc-melnikov-2012-01-14-00

Request Review of draft-ietf-marf-authfailure-report
Requested rev. no specific revision (document currently at 10)
Type Last Call Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2012-01-17
Requested 2012-01-06
Authors Hilda Fontana
Draft last updated 2012-01-14
Completed reviews Genart Last Call review of -?? by Alexey Melnikov
Genart Last Call review of -?? by Alexey Melnikov
Assignment Reviewer Alexey Melnikov
State Completed
Review review-ietf-marf-authfailure-report-genart-lc-melnikov-2012-01-14
Review completed: 2012-01-14

Review
review-ietf-marf-authfailure-report-genart-lc-melnikov-2012-01-14

I am the assigned Gen-ART reviewer for this draft. For background on 


Gen-ART, please see the FAQ at 


<

http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.






Please resolve these comments along with any other Last Call comments 


you may receive.




Document: draft-ietf-marf-authfailure-report-09
Reviewer: Alexey Melnikov
Review Date: 2012–01–14
IETF LC End Date: 2012-01-18
IESG Telechat date: 2012-01-19



Summary: This draft is ready for publication as a standard RFC, but a 


couple of minor issues remain.




Major issues: None
Minor issues:

2.2. Base 64



Sorry for missing this earlier, but RFC 4648, Section 4 is a better 


reference for base64. (Don't forget the section reference, because RFC 


4648 has 2 base64 alphabets.)





In Section 4:




spf-dns = "SPF-DNS:" : { "txt" / "spf" } [CFWS] ":" [CFWS]
domain [CFWS] ":" [CFWS] quoted-string CRLF






I think you are still missing [CFWS] before "txt" and another one before 


CRLF.






Also, you should use "(" and ")" instead of "{" and "}", as the two 


latter are not valid according to ABNF syntax.




To summarize, I think you should use:

spf-dns = "SPF-DNS:" : [CFWS] ( "txt" / "spf" ) [CFWS] ":" [CFWS]
          domain [CFWS] ":" [CFWS] quoted-string [CFWS] CRLF


Nits/editorial comments: None