Telechat Review of draft-ietf-manet-olsrv2-mib-07
review-ietf-manet-olsrv2-mib-07-genart-telechat-melnikov-2013-05-03-00

Request Review of draft-ietf-manet-olsrv2-mib
Requested rev. no specific revision (document currently at 12)
Type Telechat Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2013-05-14
Requested 2013-05-02
Authors Ulrich Herberg, Robert Cole, Thomas Clausen
Draft last updated 2013-05-03
Completed reviews Genart Last Call review of -06 by Alexey Melnikov (diff)
Genart Telechat review of -07 by Alexey Melnikov (diff)
Genart Telechat review of -08 by Alexey Melnikov (diff)
Assignment Reviewer Alexey Melnikov
State Completed
Review review-ietf-manet-olsrv2-mib-07-genart-telechat-melnikov-2013-05-03
Reviewed rev. 07 (document currently at 12)
Review result Ready with Nits
Review completed: 2013-05-03

Review
review-ietf-manet-olsrv2-mib-07-genart-telechat-melnikov-2013-05-03



I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, 
please see the FAQ at 

<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>



Document: draft-ietf-manet-olsrv2-mib-07
Reviewer:  Alexey Melnikov
Review Date: 03 May 2013
IETF LC End Date: 23 April 2013
IETF Telechat Date: 16 May 2013

Summary: This draft is ready for publication as Proposed Standard (with nits)




- Major Issues: None

- Minor Issues:



In multiple places:

          This object is persistent and when written
          the entity SHOULD save the change to
          non-volatile storage."

Why is this a SHOULD? I.e., is there a good reason not to save
such values (other than crashing while doing that, which I think is
not something you can prevent anyway.) It really looks like MUST
is actually appropriate here.






    olsrv2FHoldTime  OBJECT-TYPE
       SYNTAX      Unsigned32
       UNITS       "milliseconds"
       MAX-ACCESS  read-write
       STATUS      current
       DESCRIPTION
          "olsrv2FHoldTime corresponds to
           F_HOLD_TIME of OLSRv2 and represents the period
           after receipt of a message that is forwarded by this
           router for which that information is recorded, in order
           that the message is not forwarded again if received again.

           Guidance for setting this object may be found
           in Section 5 of the OLSRv2 specification (RFC XXXX),
           which indicates that:
              o olsrv2FHoldTime > 0
              o This parameter should be greater
                than the maximum difference in time that a
                message may take to traverse the MANET,
                taking into account any message forwarding
                jitter as well as propagation, queuing,
                and processing delays.

           This parameter SHOULD be greater
           than the maximum difference in time that a
           message may take to traverse the MANET,
           taking into account any message forwarding
           jitter as well as propagation, queuing,
           and processing delays.

I think the last paragraph is effectively identical from the one before it.
You don't do this for other attributes. I think the last paragraph should
be deleted.





- Nits:


6.2.  Relationship to the NHDP-MIB

   OLSRv2 depends on the neighborhood information that is discovered by
   [RFC6130].  In order access

In order *to* access ?

   the Objects relating to discovered
   neighbors, the State Group tables of the NHDP-MIB [RFC6779] module
   are aligned with this MIB module.



Best Regards,
Alexey