Telechat Review of draft-ietf-idr-rfc5575bis-20
review-ietf-idr-rfc5575bis-20-rtgdir-telechat-robles-2020-04-15-00

Request Review of draft-ietf-idr-rfc5575bis
Requested rev. no specific revision (document currently at 27)
Type Telechat Review
Team Routing Area Directorate (rtgdir)
Deadline 2020-04-15
Requested 2020-03-30
Requested by Alvaro Retana
Authors Christoph Loibl, Susan Hares, Robert Raszuk, Danny McPherson, Martin Bacher
Draft last updated 2020-04-15
Completed reviews Genart Last Call review of -20 by Gyan Mishra (diff)
Secdir Last Call review of -20 by Yoav Nir (diff)
Tsvart Last Call review of -20 by Jana Iyengar (diff)
Rtgdir Telechat review of -20 by Ines Robles (diff)
Assignment Reviewer Ines Robles 
State Completed
Review review-ietf-idr-rfc5575bis-20-rtgdir-telechat-robles-2020-04-15
Posted at https://mailarchive.ietf.org/arch/msg/rtg-dir/yRAUFwaclKnZ_PiM53a6a_1batI
Reviewed rev. 20 (document currently at 27)
Review result Has Nits
Review completed: 2020-04-15

Review
review-ietf-idr-rfc5575bis-20-rtgdir-telechat-robles-2020-04-15

Review type: rtgdir - Telechat review
Requested version for review: 20
Deadline: 2020-04-15
Reviewer: Ines Robles

Summary:

This document defines a Border Gateway Protocol Network Layer Reachability Information (BGP NLRI) encoding format that can be used to distribute traffic Flow Specifications. It also specifies BGP Extended Community encoding formats. This document obsoletes both RFC5575 and RFC7674.

 I found the document clear and complete. Some minor nits are detailed below.

  Major issues: Not found

  Minor issues: Not found

  Nits:

1- In the Introduction, it would be nice to mention how this draft obsoletes RFC7674 and point to appendix B when referring obsoleting RFC5575.

For example, This document obsoletes "Dissemination of Flow Specification Rules" [RFC5575], whose differences can be found in Appendix B. This document obsoletes also "Clarification of the Flowspec Redirect Extended Community"[RFC7674] due to this document includes.....

- please expand iBGP --> Internal BGP  (iBGP)

2- Section 4.2.1.1

in "a -  AND bit:..." 
2.1 - "the previous term" refers to a component?
2.2 -nit: "...unset and and MUST..." => "...unset and MUST..."

3-nit Section 5: "...this draft specifies..." if it becomes RFC it would be nice to read "..this document specifies.."

Thanks for this document,

Ines.