Last Call Review of draft-ietf-idr-rfc5575bis-20
review-ietf-idr-rfc5575bis-20-genart-lc-mishra-2020-04-07-00

Request Review of draft-ietf-idr-rfc5575bis
Requested rev. no specific revision (document currently at 26)
Type Last Call Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2020-04-08
Requested 2020-03-18
Authors Christoph Loibl, Susan Hares, Robert Raszuk, Danny McPherson, Martin Bacher
Draft last updated 2020-04-07
Completed reviews Genart Last Call review of -20 by Gyan Mishra (diff)
Secdir Last Call review of -20 by Yoav Nir (diff)
Tsvart Last Call review of -20 by Jana Iyengar (diff)
Rtgdir Telechat review of -20 by Ines Robles (diff)
Assignment Reviewer Gyan Mishra
State Completed
Review review-ietf-idr-rfc5575bis-20-genart-lc-mishra-2020-04-07
Posted at https://mailarchive.ietf.org/arch/msg/gen-art/nHmcqrrJCBHXR1iW2BmiZXQKZLw
Reviewed rev. 20 (document currently at 26)
Review result Ready with Nits
Review completed: 2020-04-07

Review
review-ietf-idr-rfc5575bis-20-genart-lc-mishra-2020-04-07

Reviewer: Gyan Mishra
Review result: Ready with Minor Issues

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-rmcat-wireless-tests-08
Reviewer: Gyan Mishra
Review Date: 2020-04-7
IETF LC End Date: 2020-04-8
IESG Telechat date: Not scheduled for a telechat

Summary: Ready, but with nits and minor issues that should be addressed.   There are just a few minor points that I would like to bring up related to clarification of how BGP Flow specification works described in the introduction as well as updates to "Dissemination of Flow Specification Rules" [RFC5575] and
   "Clarification of the Flowspec Redirect Extended Community"[RFC7674].

Major issues: None

Minor issues:  
I am familiar with BGP Flow specification and would like to recommend some verbiage that may help in the introduction as far as explaining how BGP flow spec works.  Ssince the introduction has been re-written with this update, this could be a possible addition to the draft.

This could be placed at the end of the introduction if desired.
BGP flow specification is a client-server model that allows for a more granular approach to DDOS mitigation than its predecessor, “Remotely Triggered Blackhole (RTBF) which tagged a prefix with a community and sent it do a discard next hop.  BGP flow spec has two main components, the “controller” being the BGP speaker device which acts as the server side, which injects the new flowspec entry, and the client side which is the BGP speaker devices that receives the flowspec NLRI and acts on the instruction to match a particular flow with Layer 3 and Layer 4 parameters and then implements the hardware forwarding action requested. 

Nits/editorial comments:
7.  Traffic Filtering Actions
   This document defines a minimum set of Traffic Filtering Actions that
   it standardizes as BGP extended community values [RFC4360]
   
   Any mention of [RFC4360] should be updated with [RFC7153] IANA Registries for BGP Extended Communities.