Last Call Review of draft-ietf-i2rs-yang-l2-network-topology-13
review-ietf-i2rs-yang-l2-network-topology-13-yangdoctors-lc-lhotka-2020-06-23-00

Request Review of draft-ietf-i2rs-yang-l2-network-topology
Requested rev. no specific revision (document currently at 15)
Type Last Call Review
Team YANG Doctors (yangdoctors)
Deadline 2020-06-25
Requested 2020-06-11
Requested by Martin Vigoureux
Authors Jie Dong, Xiugang Wei, Qin Wu, Mohamed Boucadair, Anders Liu
Draft last updated 2020-06-23
Completed reviews Rtgdir Early review of -02 by Henning Rogge (diff)
Rtgdir Early review of -04 by Henning Rogge (diff)
Yangdoctors Early review of -04 by Ladislav Lhotka (diff)
Rtgdir Last Call review of -13 by Stig Venaas (diff)
Yangdoctors Last Call review of -13 by Ladislav Lhotka (diff)
Genart Last Call review of -13 by Meral Shirazipour (diff)
Secdir Last Call review of -13 by Christian Huitema (diff)
Secdir Telechat review of -14 by Christian Huitema (diff)
Assignment Reviewer Ladislav Lhotka
State Completed
Review review-ietf-i2rs-yang-l2-network-topology-13-yangdoctors-lc-lhotka-2020-06-23
Posted at https://mailarchive.ietf.org/arch/msg/yang-doctors/YdreFtmSj-vuLv_044DHkeebP6A
Reviewed rev. 13 (document currently at 15)
Review result Ready with Nits
Review completed: 2020-06-23

Review
review-ietf-i2rs-yang-l2-network-topology-13-yangdoctors-lc-lhotka-2020-06-23

I already reviewed revision -04 of this document with the conclusion that from YANG point of view it is ready to be published. It is still the case with the current revision -13. All my earlier comments have been addressed.

I appreciate the example in Appendix B, it is really useful. However, I discovered several problems with the JSON instance data:

- In all 6 entries of the "ietf-network-topology:link" list, commas are missing after the "source" object.

- The identifier "ietf-l2-topology:l2-termination-point-attributes" is split between two lines (7 times), which makes it invalid. While this is explained in the introductory text, I would suggest to find another way of satisfying the 72 character limit that doesn't affect the instance data validity. One option is to use the convention of draft-ietf-netmod-artwork-folding-12, but it is also possible to simply dedent the offending lines.

- According to the rules of RFC 7951, the identifier of "termination-point" list needs to be qualified with module name, i.e. "ietf-network-topology:termination-point".

- The format of "mac-address" leaves doesn't match the regex pattern of their types: semicolons rather than dashes have to be used as octet separators.