Early Review of draft-ietf-i2rs-architecture-09
review-ietf-i2rs-architecture-09-rtgdir-early-pignataro-2015-06-08-00

Request Review of draft-ietf-i2rs-architecture
Requested rev. no specific revision (document currently at 15)
Type Early Review
Team Routing Area Directorate (rtgdir)
Deadline 2015-06-08
Requested 2015-05-29
Draft last updated 2015-06-08
Completed reviews Genart Early review of -06 by Russ Housley (diff)
Genart Last Call review of -13 by Russ Housley (diff)
Secdir Early review of -07 by Charlie Kaufman (diff)
Opsdir Early review of -07 by Fred Baker (diff)
Rtgdir Early review of -06 by Russ White (diff)
Rtgdir Early review of -09 by Carlos Pignataro (diff)
Assignment Reviewer Carlos Pignataro
State Completed
Review review-ietf-i2rs-architecture-09-rtgdir-early-pignataro-2015-06-08
Reviewed rev. 09 (document currently at 15)
Review result Has Nits
Review completed: 2015-06-08

Review
review-ietf-i2rs-architecture-09-rtgdir-early-pignataro-2015-06-08



Hello,





I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the
 review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see ​

http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir





Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft.







Document: draft-ietf-i2rs-architecture-09 


Reviewer: Carlos Pignataro 


Review Date: June 5, 2015 


Intended Status: Informational







Summary:







• I have some *minor* concerns about this document that I think should be resolved before publication.







Comments:





This is an extremely well written document that describes the basic architecture, modules, and interfaces for interfacing with the routing system. Its status targets Informational. idnits reports no real nits, only some noise.








Thank you for this document!!! I hope you find these comments useful.







Major Issues:





None.





Minor Issues:





An Architecture for the Interface to the Routing System


…


Abstract





   This document describes an architecture for a standard, programmatic


   interface for state transfer in and out of the Internet routing


   system.





CMP: Is this “an architecture”, and there are other architectures for the I2RS? I have no issues with “an architecture”, but it invites these questions, including ‘is there an authoritative architecture, and is it this one? “The IETF defined architecture”?
 How about removing the “An” from the title, and qualifying the Abstract and Intro with “as specified in the IETF”?





1.  Introduction











   Network-oriented applications require




   easy access to this information 










CMP: The concept of a “network-oriented application” is a super important piece of the whole picture. While the applications are outside the scope of the architecture itself, the network-orientedness nature is a key driver, unacknowledged as a
 key architectural property, and only revisited half way down the document in Section 5. One thought for your consideration: does it make sense to make this explicit in Section 1.2, Architectural Overview, which only defines “Application”, or as a driver in
 S1.1? Just a thought.










General:










CMP: Models — wc says there are 18 instances of “data model” and 13 of “information model”. While there are statements in the Intro like “Fundamental to the I2RS are clear data models”, I think the text would benefit from a centralized small sentence
 that explains the requirements for information as well as data models for I2RS modules and services. The closest is the 1st sentence of S3.3, perhaps, but what’s required?










1.2.  Architectural Overview (and Figure 1)













   In the




   figure, Clients A and B provide access to a single application, while




   Client P provides access to multiple applications.













CMP: “Clients A and B provide access to a single application” this can be interpreted as a single Application “X” accessing both Clients A and B. I would add a “, respectively” for exampel to disambiguate.










CMP: Also, there is no text specifying whether an application can access I2RS services via more than one Agents.










6.4.1.  Routing and Label Information Bases







   Routing elements may maintain one or more Information Bases.




   Examples include Routing Information Bases such as IPv4/IPv6 Unicast




   or IPv4/IPv6 Multicast.  Another such example includes the MPLS Label




   Information Bases, per-platform or per-interface. 













CMP: or per-context (instead of/in addition to per-interface)?










8.  Operational and Manageability Considerations










CMP: Might be useful to add traceability of interactions of I2RS as a consideration.










Nits:





CMP: Some nits, small editorials, and suggestions for your considerations:





1.  Introduction







   Routers that form the internet routing infrastructure maintain state




   at various layers of detail and function.  For example, a typical










… [and]













   today's routed networks.  The I2RS is a programmatic asynchronous




   interface for transferring state into and out of the internet routing













… [and]













   Routing and Signaling:   This block represents that portion of the




      Routing Element that implements part of the internet routing













CMP: s/the internet/the Internet/ (or an internet? I think the meaning is “the Internet”)










1.1.  Drivers for the I2RS Architecture







   The I2RS architecture facilitates obtaining information from the




   router.  The I2RS architecture provides the ability to not only read




   specific information, but also to subscribe to targeted information




   streams and filtered and thresholded events.













CMP: s/streams and filtered and thresholded events/streams, filtered events, and events subject to a threshold/










1.2.  Architectural Overview













      *  An LSR that implements RSVP-TE, OSPF-TE, and PCEP and has a




         forwarding plane and associated RIB Manager,










      *  A server that runs ISIS, OSPF, BGP and uses ForCES to control a




         remote forwarding plane,










      A Routing Element may be locally managed, whether via CLI, SNMP,




      or NETCONF.













CMP: Some of these acronyms require expansion on first use. See 

https://www.rfc-editor.org/rfc-style-guide/abbrev.expansion.txt










1.2.  Architectural Overview










   I2RS Agent:   See the definition in Section 2.







   I2RS Client:   See the definition in Section 2.













CMP: This section describes the architectural elements. Section 2, however, defines “terminology”. I would move the definitions of agent and client to this place.



















   Static System State:   An I2RS agent needs access to static state on




      a routing element beyond what is contained in the routing




      subsystem.  An example of such state is specifying queueing













CMP: s/queueing/queuing/ ? Not sure :-)













   read scope:   The set of information which the I2RS client is




      authorized to read.  The read scope specifies the access













CMP: s/which/that/













   not yet available.  Instead, each router uses different information,




   different mechanisms, and different CLI which makes a standard




   interface for use by applications extremely cumbersome to develop and




   maintain.













s/which/, all of which/










  The


   identity within NACM [RFC6536] can be specify as either a user name


   or a group user name (e.g.  Root), and this name is linked a scope


   policy that contained in a a set of access control rules.










CMP: Duplicate “a”










   scope policy.  Multiple identities may link to the same role (e.g


   ability to read I2RS RIB).










CMP: s/e.g/e.g.,/










6.4.5.1.  Managing Variation: Object Classes/Types and Inheritance













  Clients which only want




   basic capabilities can operate purely in terms of base or parent




   classes, while a client needing more details or features can work




   with the supported sub-class(es).













CMP: s/which/that/










7.4.  Scope Policy Specifications


 


   As section 4.1 and 4.2 describe, each I2RS Client will have a unique


   identity and it may have a secondary identity (see section 2) to aid


   in troubleshooting.  As section 4 indicates, all authentication and


   authorization mechanisms are based on the primary Identity which


   links to a role with scope policy for for reading data, for writing










CMP: Duplicate “for”










General:










CMP: s/data-model/data model/g (unless used as an adjective :-)










— Carlos.