Last Call Review of draft-ietf-ccamp-otn-g709-info-model-11
review-ietf-ccamp-otn-g709-info-model-11-secdir-lc-kumari-2013-09-19-00

Request Review of draft-ietf-ccamp-otn-g709-info-model
Requested rev. no specific revision (document currently at 13)
Type Last Call Review
Team Security Area Directorate (secdir)
Deadline 2013-09-19
Requested 2013-09-05
Authors Sergio Belotti, Pietro Grandi, Daniele Ceccarelli, Diego Caviglia, Fatai Zhang, Dan Li
Draft last updated 2013-09-19
Completed reviews Genart Last Call review of -11 by Christer Holmberg (diff)
Genart Telechat review of -12 by Christer Holmberg (diff)
Secdir Last Call review of -11 by Warren Kumari (diff)
Assignment Reviewer Warren Kumari 
State Completed
Review review-ietf-ccamp-otn-g709-info-model-11-secdir-lc-kumari-2013-09-19
Reviewed rev. 11 (document currently at 13)
Review result Has Nits
Review completed: 2013-09-19

Review
review-ietf-ccamp-otn-g709-info-model-11-secdir-lc-kumari-2013-09-19

Be ye not afraid...
I have reviewed this document as part of the security directorate's 
ongoing effort to review all IETF documents being processed by the 
IESG.  These comments were written primarily for the benefit of the 
security area directors.  Document editors and WG chairs should treat 
these comments just like any other last call comments.


Summary for Security AD: Nothing to see here, move along...

General summary:


This document could do with a careful reading for nits and similar.
It also use a large number of acronyms that are not defined in it -- e.g: ODUflex, GFP-F, ODUk. 
While there may be really well known in some spheres, I have *no* idea what they mean.
Please explain / expand them, or (probably much easier) simply say: "Familiarity with GMPLS and <whatever> is expected, especially [References]".


The Security Considerations section contains:
"New types of information to be conveyed regard OTN containers and hierarchies and from a security standpoint this memo does not introduce further risks with respect to the information that can be currently conveyed via GMPLS protocols."
I had a really hard time parsing this sentence -- I agree that this does't seem to introduce any new security issues, but the sentence seems to missing some words. Or something.


Some nits:

draft-ietf-ccamp-gmpls-ospf-g709v3-07 is now draft-ietf-ccamp-gmpls-ospf-g709v3-08
 
draft-ietf-ccamp-gmpls-signaling-g709v3-11 is now draft-ietf-ccamp-gmpls-signaling-g709v3-12

Section 1:
O: extensions need to support [G.709-2012] is provided in [OTN-FWK].
P:  extensions needed to support [G.709-2012] is provided in [OTN-FWK].
C: s/need/needed/

Section 2.  G.709 Mapping and Multiplexing Capabilities

O: The digital OTN layered structure is comprised of digital path layer
   (ODU) and digital section layer (OTU)
P: The digital OTN layered structure is comprised of the digital path layer
   (ODU) and the digital section layer (OTU)

O:  needs to be advertised and signaled, what is already there in GMPLS and what is missing.
P: needs to be advertised and signaled, what already exists GMPLS and what is missing.


3.  Tributary Slot Granularity

O:  ITU-T recommendation defines two types of Tributary Slot (TS)
C: Which ITU-T recommendation? Reference.

O: - If both ends of a link are new cards supporting both 1.25Gbps TS
      and 2.5Gbps TS, then the link will work with 1.25Gbps TS.
C: Throughout this section you reference "new" and "old" cards. I think you need better names or simply removed the words "new" and "old". I could presumably go to my vendor and buy a card that only supports 2.5Gbps tomorrow and that would be "new" for me.


3.2.  Control Plane considerations
O:  In case they cannot, A will compute an alternate path from itself to Z (see figure 4).
P: If not, A will compute an alternate path from itself to Z (see figure 4).
or
P:  If they cannot, A will compute an alternate path from itself to Z (see figure 4).
or
P:  In the case that they cannot, A will compute an alternate path from itself to Z (see figure 4).

O: Moreover, also TS granularity information needs to be signaled.
P: Moreover, TS granularity information also needs to be signaled.

O: the signaling to permit node C (see figure 5) choose the right one
P: the signaling to permit node C (see figure 5) to choose the right one

O: towards D. In case the full ERO is provided in the signaling with
P: towards D. In the case that the full ERO is provided in the signaling with
or
P: towards D. In cases where the full ERO is provided in the signaling with 

(I stopped here) 

W



--
I once absend-mindedly ordered Three Mile Island dressing in a restaurant and, with great presence of mind, they brought Thousand Island Dressing and a bottle of chili sauce.
    -- Terry Pratchett