Last Call Review of draft-ietf-ccamp-general-constraint-encode-16
review-ietf-ccamp-general-constraint-encode-16-opsdir-lc-korhonen-2015-01-23-00

Request Review of draft-ietf-ccamp-general-constraint-encode
Requested rev. no specific revision (document currently at 20)
Type Last Call Review
Team Ops Directorate (opsdir)
Deadline 2015-01-17
Requested 2015-01-02
Authors Jianrui Han, Greg Bernstein, Young Lee, Dan Li, Wataru Imajuku
Draft last updated 2015-01-23
Completed reviews Genart Last Call review of -16 by Francis Dupont (diff)
Genart Telechat review of -19 by Francis Dupont (diff)
Secdir Last Call review of -16 by Warren Kumari (diff)
Opsdir Last Call review of -16 by Jouni Korhonen (diff)
Rtgdir Early review of -16 by Tomonori Takeda (diff)
Assignment Reviewer Jouni Korhonen
State Completed
Review review-ietf-ccamp-general-constraint-encode-16-opsdir-lc-korhonen-2015-01-23
Reviewed rev. 16 (document currently at 20)
Review result Has Nits
Review completed: 2015-01-23

Review
review-ietf-ccamp-general-constraint-encode-16-opsdir-lc-korhonen-2015-01-23

My apologies for this review being somewhat late.. Anyway, I was 


assigned as the OPS-DIR reviewer for 


draft-ietf-ccamp-general-constraint-encode-17. Since I am not an expert 


on the topic this I-D covers treat the comments accordingly. Also, you 


should treat these comments as any LC comments.




Short summary:
  The I-D is ready with minor editorial nits.

Operational & management concerns:
  None. This I-D just defines generic protocol agnostic encoding
  formats that are to be used by others. The I-D does not even require
  IANA actions.

Editorials (I use the idnits line numbering):

* line 124: WSON is never expanded. It might be obvious for the authors
  but expanding the acronym on the first use would be nice.

* Line 1157
  [Switch] G. Bernstein, Y. Lee, A. Gavler, J. Martensson, " Modeling
                                                           ^^^

* Line 303: The "Switching Cap" gets used as a short name for
  "Switching Capability" but that is not described anywhere. One the
  other hand for "Connectivity" a short name "Conn" is described.

* Line 355: The "RstType" gets introduced as a short name for
  "RestrictionType".

* Line 344: RestrictType
                   ^^^

* Line 708: "Note that that.."
                  ^^^^^^^^^^

* Line 742: "..Num Label bits"
                       ^^^ 's' missing


- Jouni