Skip to main content

NSEC and NSEC3: TTLs and Aggressive Use
draft-ietf-dnsop-nsec-ttl-05

Revision differences

Document history

Date Rev. By Action
2021-07-16
05 (System) RFC Editor state changed to AUTH48-DONE from AUTH48
2021-07-06
05 (System) RFC Editor state changed to AUTH48
2021-06-03
05 (System) RFC Editor state changed to RFC-EDITOR from EDIT
2021-06-03
05 Bernie Volz Assignment of request for Telechat review by INTDIR to Suresh Krishnan was marked no-response
2021-05-27
05 (System) IANA Action state changed to RFC-Ed-Ack from Waiting on RFC Editor
2021-05-27
05 (System) IANA Action state changed to Waiting on RFC Editor from In Progress
2021-05-27
05 (System) IANA Action state changed to In Progress from Waiting on Authors
2021-05-26
05 (System) IANA Action state changed to Waiting on Authors from In Progress
2021-05-24
05 (System) RFC Editor state changed to EDIT
2021-05-24
05 (System) IESG state changed to RFC Ed Queue from Approved-announcement sent
2021-05-24
05 (System) Announcement was received by RFC Editor
2021-05-24
05 (System) IANA Action state changed to In Progress
2021-05-24
05 Amy Vezza IESG state changed to Approved-announcement sent from Approved-announcement to be sent::AD Followup
2021-05-24
05 Amy Vezza IESG has approved the document
2021-05-24
05 Amy Vezza Closed "Approve" ballot
2021-05-24
05 Amy Vezza Ballot approval text was generated
2021-05-20
05 (System) Removed all action holders (IESG state changed)
2021-05-20
05 Cindy Morgan IESG state changed to Approved-announcement to be sent::AD Followup from IESG Evaluation
2021-05-20
05 Roman Danyliw [Ballot comment]
Thank to Tiru Reddy for the SECDIR review.

Thanks for addressing my COMMENT feedback.
2021-05-20
05 Roman Danyliw Ballot comment text updated for Roman Danyliw
2021-05-20
05 (System) IANA Review state changed to Version Changed - Review Needed from IANA OK - Actions Needed
2021-05-20
05 Peter van Dijk New version available: draft-ietf-dnsop-nsec-ttl-05.txt
2021-05-20
05 (System) New version approved
2021-05-20
05 (System) Request for posting confirmation emailed to previous authors: Peter van Dijk
2021-05-20
05 Peter van Dijk Uploaded new revision
2021-05-19
04 Francesca Palombini [Ballot Position Update] New position, No Objection, has been recorded for Francesca Palombini
2021-05-19
04 Éric Vyncke [Ballot Position Update] New position, No Objection, has been recorded for Éric Vyncke
2021-05-18
04 Benjamin Kaduk
[Ballot comment]
I put a (small) handful of editorial suggestions up at
https://github.com/PowerDNS/draft-dnsop-nsec-ttl/pull/11 .

Section 3.1, etc.

  |  The TTL of the NSEC RR …
[Ballot comment]
I put a (small) handful of editorial suggestions up at
https://github.com/PowerDNS/draft-dnsop-nsec-ttl/pull/11 .

Section 3.1, etc.

  |  The TTL of the NSEC RR that is returned MUST be the lesser of the
  |  MINIMUM field of the SOA record and the TTL of the SOA itself.
  |  This matches the definition of the TTL for negative responses in
  |  [RFC2308].  A signer MAY cause the TTL of the NSEC RR to have a
  |  deviating value after the SOA record has been updated, to allow
  |  for an incremental update of the NSEC chain.

I don't think I understand what a "deviating value" would be (and in
which direction it would deviate).

Section 3.4

  |  A resolver that supports aggressive use of NSEC and NSEC3 MAY
  |  limit the TTL of NSEC and NSEC3 records to the lesser of the
  |  SOA.MINIMUM field and the TTL of the SOA in a response, if
  |  present.  It MAY also use a previously cached SOA for a zone to
  |  find these values.

The original 8198 has "SHOULD reduce", but now we only have "MAY limit".
Why should the requirements level be weaker for the new, more-correct,
guidance?

Section 4

  If signers & DNS servers for a zone cannot immediately be updated to
  conform to this document, zone operators are encouraged to consider
  setting their SOA record TTL and the SOA MINIMUM field to the same
  value.  That way, the TTL used for aggressive NSEC and NSEC3 use
  matches the SOA TTL for negative responses.

Are there any negative consequences of such a move that would need to be
weighed against the stated benefits?

Section 8

Why is RFC 8174 only an informative reference?  Shouldn't it be given
the same treatment as RFC 2119?
2021-05-18
04 Benjamin Kaduk [Ballot Position Update] New position, No Objection, has been recorded for Benjamin Kaduk
2021-05-18
04 Matt Joras Request for Last Call review by GENART Completed: Ready. Reviewer: Matt Joras. Sent review to list.
2021-05-18
04 Robert Wilton
[Ballot comment]
Hi,

Thanks for this document.

Regarding:

3.4.  Updates to RFC8198

  [RFC8198] section 5.4 (Consideration on TTL) is completely replaced
  …
[Ballot comment]
Hi,

Thanks for this document.

Regarding:

3.4.  Updates to RFC8198

  [RFC8198] section 5.4 (Consideration on TTL) is completely replaced
  by the following text:

  |  The TTL value of negative information is especially important,
  |  because newly added domain names cannot be used while the negative
  |  information is effective.
  | 
  |  Section 5 of [RFC2308] suggests a maximum default negative cache
  |  TTL value of 3 hours (10800).  It is RECOMMENDED that validating
  |  resolvers limit the maximum effective TTL value of negative
  |  responses (NSEC/NSEC3 RRs) to this same value.
  | 
  |  A resolver that supports aggressive use of NSEC and NSEC3 MAY
  |  limit the TTL of NSEC and NSEC3 records to the lesser of the
  |  SOA.MINIMUM field and the TTL of the SOA in a response, if
  |  present.  It MAY also use a previously cached SOA for a zone to
  |  find these values.

I'm not a DNS expert, and this is just a non binding comment, but I was wondering why it is only "MAY" limit the TTL on NSEC and NSEC3 records to the lesser of the SOA.MINIMUM field and the TTL of the SOA in a response rather than a "SHOULD".

Regards,
Rob
2021-05-18
04 Robert Wilton [Ballot Position Update] New position, No Objection, has been recorded for Robert Wilton
2021-05-18
04 Alvaro Retana [Ballot Position Update] New position, No Objection, has been recorded for Alvaro Retana
2021-05-17
04 Murray Kucherawy
[Ballot comment]
Please make RFC 8174 a normative reference rather than an informative one.  (RFC 2119 already is, but the two documents together make …
[Ballot comment]
Please make RFC 8174 a normative reference rather than an informative one.  (RFC 2119 already is, but the two documents together make up BCP 14, so I don't think you can split them as was done here.)
2021-05-17
04 Murray Kucherawy [Ballot Position Update] New position, No Objection, has been recorded for Murray Kucherawy
2021-05-17
04 John Scudder [Ballot Position Update] New position, No Objection, has been recorded for John Scudder
2021-05-17
04 Roman Danyliw
[Ballot comment]
Thank to Tiru Reddy for the SECDIR review.

Section 5.  Per:

An attacker can prevent future records from appearing in a cache by …
[Ballot comment]
Thank to Tiru Reddy for the SECDIR review.

Section 5.  Per:

An attacker can prevent future records from appearing in a cache by
  seeding the cache with queries that cause NSEC or NSEC3 responses to
  be cached, for aggressive use purposes.  This document reduces the
  impact of that attack in cases where the NSEC or NSEC3 TTL is higher
  than the zone operator intended.

Shouldn’t this text read s/An attacker can prevent future records/An attacker can delay future records/?  Per Section 9 of RFC8198, “If the resolver is making aggressive use of NSEC/NSEC3, one successful attack would be able to suppress many queries for new names, up to the negative TTL."  If the timing is right, this delay could be indefinite.  Isn't the mitigation provided here that the attacker needs to seed the cache more often?
2021-05-17
04 Roman Danyliw [Ballot Position Update] New position, No Objection, has been recorded for Roman Danyliw
2021-05-16
04 Sheng Jiang Request for Last Call review by OPSDIR Completed: Ready. Reviewer: Sheng Jiang. Sent review to list.
2021-05-14
04 Erik Kline [Ballot Position Update] New position, Yes, has been recorded for Erik Kline
2021-05-12
04 Carlos Jesús Bernardos Request for Telechat review by INTDIR is assigned to Suresh Krishnan
2021-05-12
04 Carlos Jesús Bernardos Request for Telechat review by INTDIR is assigned to Suresh Krishnan
2021-05-10
04 Wassim Haddad Assignment of request for Telechat review by INTDIR to Wassim Haddad was rejected
2021-05-10
04 Lars Eggert [Ballot Position Update] New position, No Objection, has been recorded for Lars Eggert
2021-05-08
04 Tero Kivinen Request for Last Call review by SECDIR Completed: Ready. Reviewer: Tirumaleswar Reddy.K. Submission of review completed at an earlier date.
2021-05-07
04 Martin Duke [Ballot comment]
No need for a response on these:

Please expand TTL and SOA on first use.
2021-05-07
04 Martin Duke [Ballot Position Update] New position, No Objection, has been recorded for Martin Duke
2021-05-05
04 Carlos Jesús Bernardos Request for Telechat review by INTDIR is assigned to Wassim Haddad
2021-05-05
04 Carlos Jesús Bernardos Request for Telechat review by INTDIR is assigned to Wassim Haddad
2021-05-04
04 Éric Vyncke Requested Telechat review by INTDIR
2021-05-04
04 Amy Vezza Placed on agenda for telechat - 2021-05-20
2021-05-04
04 Warren Kumari Ballot has been issued
2021-05-04
04 Warren Kumari [Ballot Position Update] New position, Yes, has been recorded for Warren Kumari
2021-05-04
04 Warren Kumari Created "Approve" ballot
2021-05-04
04 Warren Kumari IESG state changed to IESG Evaluation from Waiting for AD Go-Ahead
2021-05-04
04 (System) IESG state changed to Waiting for AD Go-Ahead from In Last Call
2021-05-03
04 Tero Kivinen Request for Last Call review by SECDIR Completed: Ready. Reviewer: Tirumaleswar Reddy.K.
2021-04-30
04 (System) IANA Review state changed to IANA OK - Actions Needed from IANA - Review Needed
2021-04-30
04 Sabrina Tanamal
(Via drafts-lastcall@iana.org): IESG/Authors/WG Chairs:

The IANA Functions Operator has completed its review of draft-ietf-dnsop-nsec-ttl-04. If any part of this review is inaccurate, please let …
(Via drafts-lastcall@iana.org): IESG/Authors/WG Chairs:

The IANA Functions Operator has completed its review of draft-ietf-dnsop-nsec-ttl-04. If any part of this review is inaccurate, please let us know.

The IANA Functions Operator understands that, upon approval of this document, there is a single action which we must complete.

In the Resource Record (RR) TYPEs registry on the Domain Name System (DNS) Parameters registry page located at:

https://www.iana.org/assignments/dns-parameters/

For the following, two existing registrations:

TYPE: NSEC
Value: 47
Meaning: NSEC

TYPE: NSEC3
Value: 50
Meaning: NSEC3

the references for these registrations will have [ RFC-to-be ] added to the existing reference information.

The IANA Functions Operator understands that this is the only action required to be completed upon approval of this document.

Note:  The actions requested in this document will not be completed until the document has been approved for publication as an RFC. This message is meant only to confirm the list of actions that will be performed.

Thank you,

Sabrina Tanamal
Senior IANA Services Specialist
2021-04-22
04 Jean Mahoney Request for Last Call review by GENART is assigned to Matt Joras
2021-04-22
04 Jean Mahoney Request for Last Call review by GENART is assigned to Matt Joras
2021-04-22
04 Tero Kivinen Request for Last Call review by SECDIR is assigned to Tirumaleswar Reddy.K
2021-04-22
04 Tero Kivinen Request for Last Call review by SECDIR is assigned to Tirumaleswar Reddy.K
2021-04-22
04 Gunter Van de Velde Request for Last Call review by OPSDIR is assigned to Sheng Jiang
2021-04-22
04 Gunter Van de Velde Request for Last Call review by OPSDIR is assigned to Sheng Jiang
2021-04-20
04 Tim Wicinski


(1) RFC is Standards Track, and this is the correct RFC type.


(2)

Technical Summary:

Due to a combination of unfortunate wording in earlier documents, …


(1) RFC is Standards Track, and this is the correct RFC type.


(2)

Technical Summary:

Due to a combination of unfortunate wording in earlier documents,
aggressive use of NSEC(3) records may deny names far beyond the
intended lifetime of a denial.  This document changes the definition
of the NSEC(3) TTL to correct that situation.  This document updates
RFC 4034, RFC 4035, and RFC 5155.

Working Group Summary:

Working group consensus was strong.

Document Quality:

While these are updates to existing standards, there is an implementation section where
open source software has implemented this.

Document Shepherd:  Tim Wicinski
Responsible Area Director: Warren Kumari

(3)  The Document Shepherd did a detailed review of the document
for content as well as simple editorial checks (spelling/grammar).
The shepherd feels the document is ready for publication.

(4) The Document Shepherd has no concerns on the depth or breadth
of the reviews.

(5) There is no need for broader review.

(6) There are no concerns from the document shepherd.

(7) No IPR disclosures

(8) There is no IPR

(9) The WG Consensus on this document is solid.  There was one issue raised by Mr. StJohn on this
being a standards track document.  We believe the author worked through these issues but we wanted
the IESG to be aware of this, and welcome any guidance on the issue:
https://mailarchive.ietf.org/arch/msg/dnsop/bGJmfwLZQPBH7K72lQ8mOf3-s7k/


(10) There has been no appeals.

(11) All nits found have been addressed by the authors.

(12) No formal review needed

(13) All references have been identified as normative or informative.

(14) All normative references are in a clear state.

(15) There are no downward normative references

(16) This document will update RFCs 4034. 4035, and 5155, and they are in the abstract and the
introduction.

(17) The document shepherd confirmed the consistency and references of the
IANA Considerations section are accurate.

(18) There are no new IANA registries, only an update to the "Domain Name System
(DNS) Parameters" registry to reference this document.


(19) N/A

(20) No Yang Necessary
2021-04-20
04 Cindy Morgan IANA Review state changed to IANA - Review Needed
2021-04-20
04 Cindy Morgan
The following Last Call announcement was sent out (ends 2021-05-04):

From: The IESG
To: IETF-Announce
CC: dnsop-chairs@ietf.org, dnsop@ietf.org, draft-ietf-dnsop-nsec-ttl@ietf.org, tjw.ietf@gmail.com, warren@kumari.net …
The following Last Call announcement was sent out (ends 2021-05-04):

From: The IESG
To: IETF-Announce
CC: dnsop-chairs@ietf.org, dnsop@ietf.org, draft-ietf-dnsop-nsec-ttl@ietf.org, tjw.ietf@gmail.com, warren@kumari.net
Reply-To: last-call@ietf.org
Sender:
Subject: Last Call:  (NSEC and NSEC3 TTLs and NSEC Aggressive Use) to Proposed Standard


The IESG has received a request from the Domain Name System Operations WG
(dnsop) to consider the following document: - 'NSEC and NSEC3 TTLs and NSEC
Aggressive Use'
  as Proposed Standard

The IESG plans to make a decision in the next few weeks, and solicits final
comments on this action. Please send substantive comments to the
last-call@ietf.org mailing lists by 2021-05-04. Exceptionally, comments may
be sent to iesg@ietf.org instead. In either case, please retain the beginning
of the Subject line to allow automated sorting.

Abstract


  Due to a combination of unfortunate wording in earlier documents,
  aggressive use of NSEC and NSEC3 records may deny names far beyond
  the intended lifetime of a denial.  This document changes the
  definition of the NSEC and NSEC3 TTL to correct that situation.  This
  document updates RFC 4034, RFC 4035, RFC 5155, and RFC 8198.




The file can be obtained via
https://datatracker.ietf.org/doc/draft-ietf-dnsop-nsec-ttl/



No IPR declarations have been submitted directly on this I-D.




2021-04-20
04 Cindy Morgan IESG state changed to In Last Call from Last Call Requested
2021-04-20
04 Warren Kumari Last call was requested
2021-04-20
04 Warren Kumari Last call announcement was generated
2021-04-20
04 Warren Kumari Ballot approval text was generated
2021-04-20
04 (System) Changed action holders to Warren Kumari (IESG state changed)
2021-04-20
04 Warren Kumari IESG state changed to Last Call Requested from Publication Requested
2021-04-20
04 Warren Kumari Ballot writeup was changed
2021-04-20
04 Tim Wicinski


(1) RFC is Standards Track, and this is the correct RFC type.


(2)

Technical Summary:

Due to a combination of unfortunate wording in earlier documents, …


(1) RFC is Standards Track, and this is the correct RFC type.


(2)

Technical Summary:

Due to a combination of unfortunate wording in earlier documents,
aggressive use of NSEC(3) records may deny names far beyond the
intended lifetime of a denial.  This document changes the definition
of the NSEC(3) TTL to correct that situation.  This document updates
RFC 4034, RFC 4035, and RFC 5155.

Working Group Summary:

Working group consensus was strong.

Document Quality:

While these are updates to existing standards, there is an implementation section where
open source software has implemented this.

Document Shepherd:  Tim Wicinski
Responsible Area Director: Warren Kumari

(3)  The Document Shepherd did a detailed review of the document
for content as well as simple editorial checks (spelling/grammar).
The shepherd feels the document is ready for publication.

(4) The Document Shepherd has no concerns on the depth or breadth
of the reviews.

(5) There is no need for broader review.

(6) There are no concerns from the document shepherd.

(7) No IPR disclosures

(8) There is no IPR

(9) The WG Consensus on this document is solid.  There was one issue raised by Mr. St John on this
being a standards track document.  We believe the author worked through these issues but we wanted
the IESG to be aware of this, and welcome any guidance on the issue:
https://mailarchive.ietf.org/arch/msg/dnsop/bGJmfwLZQPBH7K72lQ8mOf3-s7k/


(10) There has been no appeals.

(11) All nits found have been addressed by the authors.

(12) No formal review needed

(13) All references have been identified as normative or informative.

(14) All normative references are in a clear state.

(15) There are no downward normative references

(16) This document will update RFCs 4034. 4035, and 5155, and they are in the abstract and the
introduction.

(17) The document shepherd confirmed the consistency and references of the
IANA Considerations section are accurate.

(18) There are no new IANA registries, only an update to the "Domain Name System
(DNS) Parameters" registry to reference this document.


(19) N/A

(20) No Yang Necessary
2021-04-20
04 Tim Wicinski Responsible AD changed to Warren Kumari
2021-04-20
04 Tim Wicinski IETF WG state changed to Submitted to IESG for Publication from WG Consensus: Waiting for Write-Up
2021-04-20
04 Tim Wicinski IESG state changed to Publication Requested from I-D Exists
2021-04-20
04 Tim Wicinski IESG process started in state Publication Requested
2021-04-20
04 Tim Wicinski IETF WG state changed to WG Consensus: Waiting for Write-Up from In WG Last Call
2021-04-20
04 Tim Wicinski


(1) RFC is Standards Track, and this is the correct RFC type.


(2)

Technical Summary:

Due to a combination of unfortunate wording in earlier documents, …


(1) RFC is Standards Track, and this is the correct RFC type.


(2)

Technical Summary:

Due to a combination of unfortunate wording in earlier documents,
aggressive use of NSEC(3) records may deny names far beyond the
intended lifetime of a denial.  This document changes the definition
of the NSEC(3) TTL to correct that situation.  This document updates
RFC 4034, RFC 4035, and RFC 5155.

Working Group Summary:

Working group consensus was strong.

Document Quality:

While these are updates to existing standards, there is an implementation section where
open source software has implemented this.

Document Shepherd:  Tim Wicinski
Responsible Area Director: Warren Kumari

(3)  The Document Shepherd did a detailed review of the document
for content as well as simple editorial checks (spelling/grammar).
The shepherd feels the document is ready for publication.

(4) The Document Shepherd has no concerns on the depth or breadth
of the reviews.

(5) There is no need for broader review.

(6) There are no concerns from the document shepherd.

(7) No IPR disclosures

(8) There is no IPR

(9) The WG Consensus on this document is solid.  There was one issue raised by Mr. St John on this
being a standards track document.  We believe the author worked through these issues but we wanted
the IESG to be aware of this, and welcome any guidance on the issue:
https://mailarchive.ietf.org/arch/msg/dnsop/bGJmfwLZQPBH7K72lQ8mOf3-s7k/


(10) There has been no appeals.

(11) All nits found have been addressed by the authors.

(12) No formal review needed

(13) All references have been identified as normative or informative.

(14) All normative references are in a clear state.

(15) There are no downward normative references

(16) This document will update RFCs 4034. 4035, and 5155, and they are in the abstract and the
introduction.

(17) The document shepherd confirmed the consistency and references of the
IANA Considerations section are accurate.

(18) There are no new IANA registries, only an update to the "Domain Name System
(DNS) Parameters" registry to reference this document.


(19) N/A

(20) No Yang Necessary
2021-02-18
04 Peter van Dijk New version available: draft-ietf-dnsop-nsec-ttl-04.txt
2021-02-18
04 (System) New version approved
2021-02-18
04 (System) Request for posting confirmation emailed to previous authors: Peter van Dijk
2021-02-18
04 Peter van Dijk Uploaded new revision
2021-02-09
03 Peter van Dijk New version available: draft-ietf-dnsop-nsec-ttl-03.txt
2021-02-09
03 (System) New version approved
2021-02-09
03 (System) Request for posting confirmation emailed to previous authors: Peter van Dijk
2021-02-09
03 Peter van Dijk Uploaded new revision
2021-01-29
02 Tim Wicinski


(1) RFC is Standards Track, and this is the correct RFC type.


(2)

Technical Summary:

Due to a combination of unfortunate wording in earlier documents, …


(1) RFC is Standards Track, and this is the correct RFC type.


(2)

Technical Summary:

Due to a combination of unfortunate wording in earlier documents,
aggressive use of NSEC(3) records may deny names far beyond the
intended lifetime of a denial.  This document changes the definition
of the NSEC(3) TTL to correct that situation.  This document updates
RFC 4034, RFC 4035, and RFC 5155.

Working Group Summary:

Working group consensus was strong.

Document Quality:

While these are updates to existing standards, there is an implementation section where
open source software has implemented this.

Document Shepherd:  Tim Wicinski
Responsible Area Director: Warren Kumari

(3)  The Document Shepherd did a detailed review of the document
for content as well as simple editorial checks (spelling/grammar).
The shepherd feels the document is ready for publication.

(4) The Document Shepherd has no concerns on the depth or breadth
of the reviews.

(5) There is no need for broader review.

(6) There are no concerns from the document shepherd.

(7) No IPR disclosures

(8) There is no IPR

(9) The WG Consensus on this document is very solid.

(10) There has been no appeals.

(11) All nits found have been addressed by the authors.

(12) No formal review needed

(13) All references have been identified as normative or informative.

(14) All normative references are in a clear state.

(15) There are no downward normative references

(16) This document will update RFCs 4034. 4035, and 5155, and they are in the abstract and the
introduction.

(17) The document shepherd confirmed the consistency and references of the
IANA Considerations section are accurate.

(18) There are no new IANA registries, only an update to the "Domain Name System
(DNS) Parameters" registry to reference this document.


(19) N/A

(20) No Yang Necessary
2021-01-29
02 Tim Wicinski IETF WG state changed to In WG Last Call from WG Document
2021-01-29
02 Tim Wicinski Notification list changed to tjw.ietf@gmail.com because the document shepherd was set
2021-01-29
02 Tim Wicinski Document shepherd changed to Tim Wicinski
2021-01-29
02 Tim Wicinski Changed consensus to Yes from Unknown
2021-01-29
02 Tim Wicinski Intended Status changed to Proposed Standard from None
2021-01-29
02 Peter van Dijk New version available: draft-ietf-dnsop-nsec-ttl-02.txt
2021-01-29
02 (System) New version accepted (logged-in submitter: Peter van Dijk)
2021-01-29
02 Peter van Dijk Uploaded new revision
2021-01-24
01 Peter van Dijk New version available: draft-ietf-dnsop-nsec-ttl-01.txt
2021-01-24
01 (System) New version accepted (logged-in submitter: Peter van Dijk)
2021-01-24
01 Peter van Dijk Uploaded new revision
2021-01-13
00 Peter van Dijk This document now replaces draft-vandijk-dnsop-nsec-ttl instead of None
2021-01-13
00 Peter van Dijk New version available: draft-ietf-dnsop-nsec-ttl-00.txt
2021-01-13
00 (System) New version accepted (logged-in submitter: Peter van Dijk)
2021-01-13
00 Peter van Dijk Uploaded new revision