Last Call Review of draft-ietf-pce-lsp-setup-type-08
review-ietf-pce-lsp-setup-type-08-secdir-lc-emery-2018-03-08-00

Request Review of draft-ietf-pce-lsp-setup-type
Requested rev. no specific revision (document currently at 10)
Type Last Call Review
Team Security Area Directorate (secdir)
Deadline 2018-03-06
Requested 2018-02-20
Other Reviews Rtgdir Last Call review of -07 by Daniele Ceccarelli (diff)
Opsdir Last Call review of -08 by Dan Romascanu (diff)
Genart Last Call review of -08 by Roni Even (diff)
Genart Telechat review of -09 by Roni Even (diff)
Review State Completed
Reviewer Shawn Emery
Review review-ietf-pce-lsp-setup-type-08-secdir-lc-emery-2018-03-08
Posted at https://mailarchive.ietf.org/arch/msg/secdir/ppSnKuebihyQvumHcSek9yYYa0Y
Reviewed rev. 08 (document currently at 10)
Review result Has Nits
Draft last updated 2018-03-08
Review completed: 2018-03-08

Review
review-ietf-pce-lsp-setup-type-08-secdir-lc-emery-2018-03-08

Reviewer: Shawn M Emery
Review result: Ready with nits

I have reviewed this document as part of the security directorate's
ongoing effort to review all IETF documents being processed by the IESG.
These comments were written primarily for the benefit of the security
area directors. Document editors and WG chairs should treat these
comments just like any other last call comments.

This draft specifies an extension to the Path Computation Element
communication
Protocol (PCEP) that allows for different path setup methods for a given
session.

The security considerations section does exist and defers security aspects
related to this draft to RFC 5440 and 8281.  I agree with this assertion.
I believe
that the base specifications cover the security concerns and ways to
mitigate
sufficiently for this protocol.  It was also good to see that PCEP is
developing
security as a forethought [RFC 8253].

General comments:

None.

Editorial comments:

s/A Path Computation Element can/A Path Computation Element (PCE) can/

s/extension to PCEP/extension to the PCE communication Protocol (PCEP)/

s/be able take control/be able to take control/


Shawn.
--