Last Call Review of draft-ietf-netconf-ssh-client-server-03
review-ietf-netconf-ssh-client-server-03-yangdoctors-lc-bierman-2017-07-28-00

Request Review of draft-ietf-netconf-ssh-client-server-03
Requested rev. 03 (document currently at 12)
Type Last Call Review
Team YANG Doctors (yangdoctors)
Deadline 2017-07-31
Requested 2017-07-10
Requested by Mehmet Ersue
Other Reviews
Review State Completed
Reviewer Andy Bierman
Review review-ietf-netconf-ssh-client-server-03-yangdoctors-lc-bierman-2017-07-28
Posted at https://mailarchive.ietf.org/arch/msg/yang-doctors/-Qc3rUWNinetJDp3GWJOgFvgiqA
Reviewed rev. 03 (document currently at 12)
Review result Ready with Nits
Draft last updated 2017-07-28
Review completed: 2017-07-28

Review
review-ietf-netconf-ssh-client-server-03-yangdoctors-lc-bierman-2017-07-28

Review: draft-ietf-netconf-ssh-client-server-03

Modules:
 (M1) ietf-ssh-client@2017-06-13.yang
 (M2) ietf-ssh-common@2017-06-13.yang
 (M3) ietf-ssh-server@2017-06-13.yang


YANG Usage:

 I did not find anything wrong in either module.
 pyang and yangdump-pro do not report any errors or warnings.

Comments:

C1:

 (M3) transport-params leafrefs

 Example of <transport-params> in sec. 4.2 shows ietf-ssh-common
 as the module namespace but this will never happen in real usage.
 People will copy the various identityref examples in this section
 and not encode the identityref prefix correctly.

C2:

Sec 1.2 Tree Diagrams

Old text should be replaced with reference to
draft-ietf-netmod-yang-tree-diagrams-01

C3:

 (M1) IETF copyright says 2014; change to 2017
 (M3) IETF copyright says 2014; change to 2017