Last Call Review of draft-ietf-lamps-rfc5751-bis-07
review-ietf-lamps-rfc5751-bis-07-genart-lc-schinazi-2018-04-26-00

Request Review of draft-ietf-lamps-rfc5751-bis
Requested rev. no specific revision (document currently at 12)
Type Last Call Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2018-04-27
Requested 2018-04-13
Other Reviews Opsdir Last Call review of -07 by Zitao Wang (diff)
Secdir Last Call review of -07 by Daniel Migault (diff)
Secdir Telechat review of -10 by Daniel Migault (diff)
Review State Completed
Reviewer David Schinazi
Review review-ietf-lamps-rfc5751-bis-07-genart-lc-schinazi-2018-04-26
Posted at https://mailarchive.ietf.org/arch/msg/gen-art/7wnr9oRUyTujNC1gTRppMD5ehcY
Reviewed rev. 07 (document currently at 12)
Review result Ready
Draft last updated 2018-04-26
Review completed: 2018-04-26

Review
review-ietf-lamps-rfc5751-bis-07-genart-lc-schinazi-2018-04-26

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-lamps-rfc5751-bis-07
Reviewer: David Schinazi
Review Date: 2018-04-26
IETF LC End Date: 2018-04-27
IESG Telechat date: Not scheduled for a telechat

Summary:
    This document is clearly written and does a nice job of explaining the rationale and historical context of the decisions it made.

Major issues:
    None noticed during this review

Minor issues:
    I was slightly confused by the description of AuthEnvelopedData in 2.4.4: it seems to describe data protected by a symmetric AEAD but then mentions asymmetric keys. But this could be due to my lack of expertise in S/MIME.

Nits/editorial comments: 
    I believe the RFC2119 reference should also mention RFC8174.