Last Call Review of draft-ietf-ippm-twamp-yang-08
review-ietf-ippm-twamp-yang-08-secdir-lc-montville-2018-04-25-00

Request Review of draft-ietf-ippm-twamp-yang
Requested rev. no specific revision (document currently at 13)
Type Last Call Review
Team Security Area Directorate (secdir)
Deadline 2018-04-27
Requested 2018-04-09
Other Reviews Yangdoctors Early review of -00 by Jan Lindblad (diff)
Opsdir Last Call review of -09 by Victor Kuarsingh (diff)
Genart Last Call review of -07 by Pete Resnick (diff)
Genart Telechat review of -11 by Pete Resnick (diff)
Review State Completed
Reviewer Adam Montville
Review review-ietf-ippm-twamp-yang-08-secdir-lc-montville-2018-04-25
Posted at https://mailarchive.ietf.org/arch/msg/secdir/QZnH1B9r6rdnndFQXUexEJXSFlE
Reviewed rev. 08 (document currently at 13)
Review result Ready
Draft last updated 2018-04-25
Review completed: 2018-04-25

Review
review-ietf-ippm-twamp-yang-08-secdir-lc-montville-2018-04-25

I have reviewed this document as part of the security directorate's ongoing effort to review all IETF documents being processed by the IESG.  These comments were written primarily for the benefit of the security area directors.  Document editors and WG chairs should treat these comments just like any other last call comments.

The summary of the review is: Ready; the Security Considerations cover in-transit protections well enough, and recommends controlling access to writable nodes.

One suggestion I have is that the security considerations could do a better job drawing a straight line between "a number of nodes...which are writeable" and the "Examples of notes that are particularly vulnerable..." The example is simply, "...several timeout values put in the protocol to protect against sessions that are not active but are consuming resources." This would suggest that controlling access to writable timeout values would mitigate denial of service, which could be beneficial to state explicitly. Are all of the other writable nodes of the same character, or would some lead to, for example, privilege escalation? In other words, while doing so is probably not strictly necessary for the success of the draft, making the security issues as clear as possible for at least each category of writable node seems like a good idea to help those who may not otherwise be aware.