Skip to main content

Policy Behavior for Well-Known BGP Communities
draft-ietf-grow-wkc-behavior-08

Yes

Warren Kumari

No Objection

(Adam Roach)
(Alexey Melnikov)
(Barry Leiba)
(Benjamin Kaduk)
(Magnus Westerlund)

Abstain


Note: This ballot was opened for revision 04 and is now closed.

Warren Kumari
Yes
Roman Danyliw
No Objection
Comment (2019-06-11 for -07) Sent
(1) How this draft updates RFC1997 isn’t clear to me.  I also don’t see how it is a standards track document.  Excluding the helpful enumeration of how the user interfaces of various implementations work, the draft appears to prescribe:

-- Section 5: when new attributes are defined in protocol spec they should be clear in their expected behavior 

-- Section 6, Paragraph 3: vendors should document their implementations (and I agree with Alissa and Alvaro who recommended this be MUST)

-- Section 6, Paragraph 4:  vendors must continue to implement the same behavior for the user interface of the “set” directive  

For me these summarize to document what you are doing; and keep doing whatever you have done before (perhaps more precisely, continue to do in the future what you have done in the past).  This doesn’t seem like new or clarifying behavior.

(2) A few editorial nits:
-- Abstract.  Editorial Nit.
s/Well-Known BGP Communities are manipulated differently across various current implementations/
Well-Known BGP Communities are manipulated differently in current implementations/

-- Abstract. Editorial. s/.././

-- Section 5.  Each line in this section appears to start with a “>” as if cut and paste from an email.
Ignas Bagdonas Former IESG member
Yes
Yes (2019-06-12 for -07) Not sent
This document seems to update 1998 more than 1997.
Adam Roach Former IESG member
No Objection
No Objection (for -07) Not sent

                            
Alexey Melnikov Former IESG member
No Objection
No Objection (for -07) Not sent

                            
Alissa Cooper Former IESG member
No Objection
No Objection (2019-06-10 for -06) Sent
Requirements language:

Please use the RFC 8174 boilerplate.

Section 4.1: 

s/is not really on IANA's list/is not individually named on IANA's list/

Section 5: 

I'm not sure what the '>' character indicates.

Section 6:

"Vendors SHOULD clearly document the behavior of "set" directive in their implementations." I'm not sure normative language makes sense here (otherwise, what is the rationale for not using MUST?).
Barry Leiba Former IESG member
No Objection
No Objection (for -07) Not sent

                            
Benjamin Kaduk Former IESG member
No Objection
No Objection (for -06) Not sent

                            
Deborah Brungard Former IESG member
No Objection
No Objection (2019-06-12 for -07) Not sent
While I noted other reviews were questioning PS status, I think it is appropriate.

I would have preferred a stronger statement for the following:
Vendors SHOULD clearly document/s/Vendors MUST clearly document
Magnus Westerlund Former IESG member
No Objection
No Objection (for -07) Not sent

                            
Martin Vigoureux Former IESG member
No Objection
No Objection (2019-06-13 for -07) Sent for earlier
Hi,

thank you for this document.

I'm not clear about something and would like to better understand.

I read this:
   Vendors MUST ensure that their implementations' "set" directive
   treatment of any specific community does not change if/when that
   community becomes a new Well-Known Community through future
   standardization.  For most implementations, this means that the "set"
   directive MUST continue to remove the community; for those
   implementations where the "set" directive removes no communities,
   that behavior MUST continue.
as saying "do not change your implementation behaviour for the existing WKC, and also apply that same behaviour to any future WKC that might be defined".

If this reading is correct, I am under the impression that:
   When establishing new [RFC1997]-like attributes (large communities,
   wide communities, etc.), RFC authors should state explicitly how the
   > new attribute is to be handled.
is in conflict with the above.
I know it's not a 2119/8174 keyword, but still, this seems to allow authors to specify how a future WKC should be treated by 'set' or 'delete *:*' and thus, for some implementations, that behavioral requirement will be in conflict with their current behaviour (which must not change).

Thank you
Mirja Kühlewind Former IESG member
No Objection
No Objection (2019-05-20 for -04) Sent
I think this document should update RFC1997.
Suresh Krishnan Former IESG member
No Objection
No Objection (2019-06-11 for -07) Sent
I found the documentation of the various set community behaviors interesting and useful.

* Section 5

It is unclear what this section is recommending to RFC authors. What exactly should they state explicitly? Can you please clarify and expand a bit.

   When establishing new [RFC1997]-like attributes (large communities,
   wide communities, etc.), RFC authors should state explicitly how the
   > new attribute is to be handled.
Alvaro Retana Former IESG member
Abstain
Abstain (2019-06-11 for -07) Sent
Consistent behavior is important.  Understanding that behavior to achieve consistent operations is even more important.

However, I believe that this document doesn't provide the substance needed to achieve or guarantee consistency in the future.  Specifically, the Normative content (mostly in §6) doesn't define a specific behavior...instead it basically boils down to "keep doing whatever you're doing...and document it if you want to"...

The language can always be improved, but unless a specific behavior is specified I don't think there is much value is publishing this document as an RFC.  According to the Shepherd, the consensus on this document is solid in the WG.  I then don't expect significant changes, and don't want to delay publication, so I am ABSTAINing.

I do have some specific comments that hopefully may help improve the document.


=======

(1) What is the Update to rfc1997?  Please mention what it is in the Abstract and Introduction.

I don't see a specific update to rfc1997, as in changing the behavior, for example.  But, based on the e-mail archive, it seems that the intent is to point readers of rfc1997 to this document...at least say that.


(2) Document Status 

As others have mentioned, and specially because this document doesn't really specify anything, I don't think it belongs in the Standards Track.  I think that tagging it as an update to rfc1997 is not a great excuse to make it a Proposed Standard.  Unfortunately, we have no other way to point readers of rfc1997 to this document.

I also don't think that BCP is appropriate because it simply points at the fact that inconsistencies exist...  [See more below.]

I think that this document is better suited to be Informational.  Other documents that have addressed the use of communities have been published as Informational; for example rfc1998, rfc8195...


(3) Introduction

   This document recommends specific actions to limit future
   inconsistency, namely BGP implementors MUST NOT create further
   inconsistencies from this point forward.

How can the creation of inconsistencies be Normatively enforced?  I understand that this whole document is about addressing inconsistencies, which I think is a valid use of the rfc2119 keywords...but I don't understand what action is expected out of the statement.   s/MUST NOT/must not

I do think that the Action Items (§6) represent better guidance than the statement above.  


(3) Action Items 

(3a) "Vendors SHOULD clearly document the behavior of "set" directive in their implementations."  Why is MUST not used?  IOW, when it is ok for vendors not to clearly document the behavior?  If the intent is not to mandate what vendors do, then please s/SHOULD/should...but I thought that was the intent in Standards Track documents...

(3b) Given that this document is about addressing inconsistencies, I am sad by this paragraph:

   Vendors MUST ensure that their implementations' "set" directive
   treatment of any specific community does not change if/when that
   community becomes a new Well-Known Community through future
   standardization.  For most implementations, this means that the "set"
   directive MUST continue to remove the community; for those
   implementations where the "set" directive removes no communities,
   that behavior MUST continue.

Note first that "MUST ensure that..."set" directive...does not change" is hard to enforce unless the behavior is clearly documented, but that is not absolutely required...

Second...the text Normatively (MUST) allows for the behavior to remain the way it is.  This makes me sad because I hoped for this document to define a specific behavior...instead it basically boils down to "keep doing whatever you're doing...and document it if you want to"... :-(



(5) Note for Those Writing RFCs for New Community-Like Attributes (§5)

   "...RFC authors should state explicitly how the new attribute is to be handled."

This seems to be the one piece of important information in this document...but it is not mandatory.  Also, based on the rest of the document, I think you explicitly mean more than general handling...but probably mean also what implementations are expected to do in relation to filtering, etc.  If so, please be explicit.

Also, what are "community-like attributes"?  The examples mentioned are also communities... I think that where specific attributes exist, they should be explicitly mentioned: rfc4360, rfc8092...



(6) Nits...

(6a) Table 1: There is one reference (rfc7611) -- or at least it looks like a reference, but there's no corresponding entry in the References section.  Please be consistent: either add references to the Table (and the References section), or not.  I think that in this case you should.

(6b) "On Extreme networks' Brocade NetIron: "set community X" removes all communities and sets X."  Most of the other text in this section makes the point of indicating "all communities, Well-Known or otherwise"...is there a difference in behavior here?